Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

remove predefined values from cubic-bezier() #11786

Merged
merged 1 commit into from
Nov 19, 2015
Merged

remove predefined values from cubic-bezier() #11786

merged 1 commit into from
Nov 19, 2015

Conversation

myakura
Copy link
Contributor

@myakura myakura commented Oct 7, 2015

looks like 1295cfe#diff-0 unintentionally introduced these predef values. so taking them out.

@abose
Copy link
Contributor

abose commented Oct 7, 2015

Thanks @myakura for contributing to brackets.
The Contributor License Agreement should be signed before we can accept the change.

@nethip
Copy link
Contributor

nethip commented Oct 7, 2015

@redmunds Would you mind reviewing this change?

@petetnt
Copy link
Collaborator

petetnt commented Oct 7, 2015

I think those values are be intentional: the values are equivalent to ease-in-out, which is often used* as the default value for cubic-bezier curves because it nicely shows what it's meant for. Other default would be equal to linear (0,0,1,1), which isn't that nice IMO.

  • citation needed, might just be my own opinion.

@nethip
Copy link
Contributor

nethip commented Oct 7, 2015

Thanks @petetnt for quickly jumping in and trying to analyze this 👍

@redmunds
Copy link
Contributor

redmunds commented Oct 7, 2015

@nethip Yes, @petetnt is correct about the original reason for using predefined values. But, I think that @marcelgerber fixed it so that cubic-bezier() will now give the same result, so predefined values may no longer be necessary.

@myakura
Copy link
Contributor Author

myakura commented Oct 9, 2015

@abose thx. signed!

@abose abose added this to the Release 1.6 milestone Oct 9, 2015
abose added a commit that referenced this pull request Nov 19, 2015
remove predefined values from cubic-bezier()
@abose abose merged commit 94f4f6e into adobe:master Nov 19, 2015
@abose
Copy link
Contributor

abose commented Nov 19, 2015

Merged for 1.6. Thanks @myakura

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants