duplicateText amended to handle end-of-file scenarios, adding new line; ... #1179
Conversation
…e; testing thereof
ghost
assigned 
|
I'll review this in the next 1-2 days. |
|
@jedverity: Before we can accept this into the project, we need you to sign the Contributor License Agreement -- http://dev.brackets.io/brackets-contributor-license-agreement.html |
|
I did sign that a couple of days ago. Do you not have a record of it? Let me know and I'll sign it again. On Thursday, June 28, 2012 at 11:53 PM, Peter Thiess wrote:
|
| if (!hasSelection) { | ||
| sel.start.ch = 0; | ||
| sel.end = {line: sel.start.line + 1, ch: 0}; | ||
| delimiter = typeof doc.getLine(sel.end.line) == "undefined" ? "\n" : delimiter; |
There was a problem hiding this comment.
- It'd be cleaner to check
sel.end.lineagainsteditor.totalLines()here. (Also, note: to pass JSLint, use===instead of==for comparisons). - Since that doesn't use
doc, you could leave its var declaration down below. - The use of ternary operator feels a little weird here since it's a no-op on one branch. I think it'd read better if this was just a standard if statement.
There was a problem hiding this comment.
I think you mean editor.lineCount() but let me know if I'm missing something!
|
Great job @jedverity -- thanks for the solid fix! Apologies for the long delay in reviewing -- vacation got the better of me. Feel free to ping me on IRC if you want to discuss any of the comments (or just post back here of course). I've verified your 'Contributor License Agreement' record, so no worries there. |
|
Thank you, @peterflynn ! I've pushed the changes as you requested (though not sure why it's showing up as my alternative username). |
|
Two more changes needed and then I think we're good to merge! Thanks again! Re "totalLines()" vs. Re declaring all vars at the top: wouldn't be the first time it's been debated here :-) Officially the Brackets coding guide is neutral (either style is ok), but personally I have a pretty strong preference for declaring vars where they're initialized -- only in a project like Brackets where passing JSLint is a strict requirement. Combining JSLint with lower-down var declarations automatically catches the class of bugs where you use a var before it's been initialized (which JSLint is not smart enough to do if you move the var declaration earlier). The more bugs you find right when you hit Cmd+S, the less time spent wading around the debugger or the GitHub bug list later ;-) |
|
Great -- thanks! Merging now... |
Fix bug #926: amend duplicateText() to handle end-of-file scenarios, with unit test
...testing thereof; Replacement for previous pull request. issue #926