This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixed htmlmixed highlighting. #12422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and the syntax highlighting LGTM. Indentation is broken though (resets to 0 on every line) on the Should and too so that they show up on |
|
I've added them. |
| @@ -66,7 +66,8 @@ | |||
| "attribOptions": ["auto", "inherit", "optimizeQuality", "optimizeSpeed"] | |||
| }, | |||
| "contentScriptType": { | |||
| "attribOptions": ["application/ecmascript", "application/javascript", "application/x-ecmascript", "application/x-javascript", "text/ecmascript", "text/javascript", "text/jscript", "text/livescript", "text/tcl", "text/x-ecmascript", "text/x-javascript"] | |||
| "attribOptions": ["application/ecmascript", "application/javascript", "application/x-ecmascript", "application/x-javascript", "text/ecmascript", "text/javascript", "text/jscript", "text/livescript", "text/tcl", "text/x-ecmascript", "text/x-javascript", | |||
| "text/babel", "text/jsx"] | |||
There was a problem hiding this comment.
NIT: this should go in line 69.
| @@ -212,7 +212,8 @@ | |||
| "menu/type": { "attribOption": ["context", "list", "toolbar"] }, | |||
| "ol/type": { "attribOption": ["1", "a", "A", "i", "I"] }, | |||
| "script/type": { "attribOption": ["text/javascript", "text/ecmascript", "text/jscript", "text/livescript", "text/tcl", "text/x-javascript", "text/x-ecmascript", | |||
| "application/x-javascript", "application/x-ecmascript", "application/javascript", "application/ecmascript"] }, | |||
| "application/x-javascript", "application/x-ecmascript", "application/javascript", "application/ecmascript", | |||
There was a problem hiding this comment.
This one also has the somewhat arbitrary new lines. But these were here before. No need to fix.
|
@MiguelCastillo Thank you. |
|
You bet! Thank you for your PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
text/babelandtext/jsxto thejsxmode.My angular template (
ng-template) weren't syntax hightlighted so I changed the mode.I'm not sure is totally correct but seems to work ok.
This should fix #12208 too.
/cc @marcelgerber @petetnt