Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Use opn instead of open. #12641

Merged
merged 1 commit into from
Aug 10, 2016
Merged

Use opn instead of open. #12641

merged 1 commit into from
Aug 10, 2016

Conversation

ficristo
Copy link
Collaborator

@ficristo ficristo commented Aug 2, 2016

Installed with node@3 and npm install --production

@petetnt
Copy link
Collaborator

petetnt commented Aug 3, 2016

This line:

needs to be changed to var open = require("opn"); too right?

Installed with node@3 and npm install --production
@ficristo
Copy link
Collaborator Author

ficristo commented Aug 3, 2016

@petetnt of course... fixed.

@marcelgerber
Copy link
Contributor

I think we need some sort of https://github.com/adobe/brackets-shell/pull/505/files for this one, too, so it works when installed with the .deb file.
LGTM otherwise.

@ficristo
Copy link
Collaborator Author

ficristo commented Aug 10, 2016

we need some sort of

I guess I learn something every day

I've opened two PR one for maste and one for linux-1547 branch on brackets-shell

@marcelgerber
Copy link
Contributor

LGTM. Also tested this with an installer build on Linux to make sure it works.
Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants