Move most inline jslint directives to config files

.brackets.json

@@ -2,10 +2,28 @@
     "jslint.options": {
         "vars": true,
         "plusplus": true,
+        "browser": false,
         "devel": true,
         "nomen": true,
+        "indent": 4,
         "maxerr": 50,
-        "es5": true
+        "es5": true,
+        "predef": [
+            "brackets",
+
+            "require",
+            "define",
+            "$",
+
+            "window",
+            "setTimeout",
+            "clearTimeout",
+
+            "ArrayBuffer",
+            "XMLHttpRequest",
+            "Uint32Array",
+            "WebSocket"
+        ]
     },
     "defaultExtension": "js",
     "language": {

.eslintrc.json

@@ -54,15 +54,17 @@
     "globals": {
         "brackets": false,
 
+        "require": false,
+        "define": false,
+        "$": false,
+
         "window": false,
-        "alert": false,
-        "document": false,
-        "localStorage": false,
-        "navigator": false,
         "setTimeout": false,
+        "clearTimeout": false,
 
-        "require": false,
-        "define": false,
-        "$": false
+        "ArrayBuffer": false,
+        "XMLHttpRequest": false,
+        "Uint32Array": false,
+        "WebSocket": false
     }
 }

Gruntfile.js

@@ -20,7 +20,9 @@
  * DEALINGS IN THE SOFTWARE.
  *
  */
-/*global module, require*/
+
+/*jslint node: true */
+
 module.exports = function (grunt) {
     'use strict';
 

src/LiveDevelopment/Agents/CSSAgent.js

@@ -21,9 +21,7 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define, $ */
+/*jslint forin: true */
 
 /**
  * CSSAgent keeps track of loaded style sheets and allows reloading them

src/LiveDevelopment/Agents/ConsoleAgent.js

@@ -21,10 +21,6 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define */
-
 /**
  * ConsoleAgent forwards all console message from the remote console to the
  * local console.

src/LiveDevelopment/Agents/DOMAgent.js

@@ -21,10 +21,6 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define, $, XMLHttpRequest */
-
 /**
  * DOMAgent constructs and maintains a tree of {DOMNode}s that represents the
  * rendered DOM tree in the remote browser. Nodes can be accessed by id or

src/LiveDevelopment/Agents/DOMHelpers.js

@@ -21,9 +21,7 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define */
+/*jslint regexp: true */
 
 /**
  * DOMHelpers is a collection of functions used by the DOMAgent exports `eachNode(src, callback)`

src/LiveDevelopment/Agents/DOMNode.js

@@ -21,9 +21,7 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define, $ */
+/*jslint forin: true */
 
 /**
  * DOMNode represents a node in the DOM tree. It is constructed from a payload

src/LiveDevelopment/Agents/EditAgent.js

@@ -21,10 +21,6 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define */
-
 /**
  * EditAgent propagates changes from the in-document editor to the source
  * document.

src/LiveDevelopment/Agents/GotoAgent.js

@@ -22,8 +22,7 @@
  */
 
 
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define, brackets, $, window */
+/*jslint forin: true, regexp: true */
 
 /**
  * GotoAgent constructs and responds to the in-browser goto dialog.

src/LiveDevelopment/Agents/HighlightAgent.js

@@ -21,10 +21,6 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define */
-
 /**
  * HighlightAgent dispatches events for highlight requests from in-browser
  * highlight requests, and allows highlighting nodes and rules in the browser.

src/LiveDevelopment/Agents/NetworkAgent.js

@@ -21,10 +21,6 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define */
-
 /**
  * NetworkAgent tracks all resources loaded by the remote debugger. Use
  * `wasURLRequested(url)` to query whether a resource was loaded.

src/LiveDevelopment/Agents/RemoteAgent.js

@@ -21,9 +21,7 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define, $, window */
+/*jslint regexp: true */
 
 /**
  * RemoteAgent defines and provides an interface for custom remote functions

src/LiveDevelopment/Agents/RemoteFunctions.js

@@ -21,10 +21,8 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, browser: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*jshint unused: false */
-/*global window, navigator, Node, console */
+/*jslint forin: true */
+/*global Node */
 /*theseus instrument: false */
 
 /**
@@ -47,7 +45,7 @@ function RemoteFunctions(experimental) {
 
     // determine whether an event should be processed for Live Development
     function _validEvent(event) {
-        if (navigator.platform.substr(0, 3) === "Mac") {
+        if (window.navigator.platform.substr(0, 3) === "Mac") {
             // Mac
             return event.metaKey;
         } else {
@@ -127,7 +125,7 @@ function RemoteFunctions(experimental) {
                 y = offset.top + this.element.offsetHeight;
 
             // create the container
-            this.body = document.createElement("div");
+            this.body = window.document.createElement("div");
             this.body.style.setProperty("z-index", 2147483647);
             this.body.style.setProperty("position", "absolute");
             this.body.style.setProperty("left", x + "px");
@@ -143,7 +141,7 @@ function RemoteFunctions(experimental) {
         },
 
         addItem: function (target) {
-            var item = document.createElement("div");
+            var item = window.document.createElement("div");
             item.style.setProperty("padding", "2px 6px");
             if (this.body.childNodes.length > 0) {
                 item.style.setProperty("border-top", "1px solid #ccc");
@@ -154,7 +152,7 @@ function RemoteFunctions(experimental) {
             item.addEventListener("click", this.onClick.bind(this, target.url));
 
             if (target.file) {
-                var file = document.createElement("i");
+                var file = window.document.createElement("i");
                 file.style.setProperty("float", "right");
                 file.style.setProperty("margin-left", "12px");
                 file.innerHTML = " " + target.file;
@@ -168,16 +166,16 @@ function RemoteFunctions(experimental) {
                 this.body = this.createBody();
             }
             if (!this.body.parentNode) {
-                document.body.appendChild(this.body);
+                window.document.body.appendChild(this.body);
             }
-            document.addEventListener("click", this.remove);
+            window.document.addEventListener("click", this.remove);
         },
 
         remove: function () {
             if (this.body && this.body.parentNode) {
-                document.body.removeChild(this.body);
+                window.document.body.removeChild(this.body);
             }
-            document.removeEventListener("click", this.remove);
+            window.document.removeEventListener("click", this.remove);
         }
 
     };
@@ -315,7 +313,7 @@ function RemoteFunctions(experimental) {
         },
 
         add: function (element, doAnimation) {
-            if (this._elementExists(element) || element === document) {
+            if (this._elementExists(element) || element === window.document) {
                 return;
             }
             if (this.trigger) {
@@ -395,7 +393,7 @@ function RemoteFunctions(experimental) {
 
     function onMouseMove(event) {
         onMouseOver(event);
-        document.removeEventListener("mousemove", onMouseMove);
+        window.document.removeEventListener("mousemove", onMouseMove);
     }
 
     function onClick(event) {
@@ -412,11 +410,11 @@ function RemoteFunctions(experimental) {
 
     function onKeyUp(event) {
         if (_setup && !_validEvent(event)) {
-            document.removeEventListener("keyup", onKeyUp);
-            document.removeEventListener("mouseover", onMouseOver);
-            document.removeEventListener("mouseout", onMouseOut);
-            document.removeEventListener("mousemove", onMouseMove);
-            document.removeEventListener("click", onClick);
+            window.document.removeEventListener("keyup", onKeyUp);
+            window.document.removeEventListener("mouseover", onMouseOver);
+            window.document.removeEventListener("mouseout", onMouseOut);
+            window.document.removeEventListener("mousemove", onMouseMove);
+            window.document.removeEventListener("click", onClick);
             _localHighlight.clear();
             _localHighlight = undefined;
             _setup = false;
@@ -425,11 +423,11 @@ function RemoteFunctions(experimental) {
 
     function onKeyDown(event) {
         if (!_setup && _validEvent(event)) {
-            document.addEventListener("keyup", onKeyUp);
-            document.addEventListener("mouseover", onMouseOver);
-            document.addEventListener("mouseout", onMouseOut);
-            document.addEventListener("mousemove", onMouseMove);
-            document.addEventListener("click", onClick);
+            window.document.addEventListener("keyup", onKeyUp);
+            window.document.addEventListener("mouseover", onMouseOver);
+            window.document.addEventListener("mouseout", onMouseOut);
+            window.document.addEventListener("mousemove", onMouseMove);
+            window.document.addEventListener("click", onClick);
             _localHighlight = new Highlight("#ecc", true);
             _setup = true;
         }
@@ -479,7 +477,7 @@ function RemoteFunctions(experimental) {
     // highlight a rule
     function highlightRule(rule) {
         hideHighlight();
-        var i, nodes = document.querySelectorAll(rule);
+        var i, nodes = window.document.querySelectorAll(rule);
         for (i = 0; i < nodes.length; i++) {
             highlight(nodes[i]);
         }
@@ -500,7 +498,7 @@ function RemoteFunctions(experimental) {
     function _scrollHandler(e) {
         // Document scrolls can be updated immediately. Any other scrolls
         // need to be updated on a timer to ensure the layout is correct.
-        if (e.target === document) {
+        if (e.target === window.document) {
             redrawHighlights();
         } else {
             if (_remoteHighlight || _localHighlight) {
@@ -817,7 +815,7 @@ function RemoteFunctions(experimental) {
     }
 
     function getSimpleDOM() {
-        return JSON.stringify(_domElementToJSON(document.documentElement));
+        return JSON.stringify(_domElementToJSON(window.document.documentElement));
     }
 
     // init

src/LiveDevelopment/Agents/ScriptAgent.js

@@ -21,10 +21,6 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define, $ */
-
 /**
  * ScriptAgent tracks all executed scripts, defines internal breakpoints, and
  * interfaces with the remote debugger.

src/LiveDevelopment/Documents/CSSDocument.js

@@ -21,9 +21,7 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define, $ */
+/*jslint forin: true */
 
 /**
  * CSSDocument manages a single CSS source document

src/LiveDevelopment/Documents/CSSPreprocessorDocument.js

@@ -21,10 +21,6 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, maxerr: 50 */
-/*global define */
-
 /**
  * CSSPreprocessorDocument manages a single LESS or SASS source document
  *

src/LiveDevelopment/Documents/HTMLDocument.js

@@ -21,10 +21,6 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define */
-
 /**
  * HTMLDocument manages a single HTML source document
  *

src/LiveDevelopment/Documents/JSDocument.js

@@ -21,9 +21,7 @@
  *
  */
 
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define */
+/*jslint forin: true */
 
 /**
  * JSDocument manages a single JavaScript source document

src/LiveDevelopment/Inspector/Inspector.js

@@ -21,10 +21,8 @@
  *
  */
 
-
-
-/*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, forin: true, maxerr: 50, regexp: true */
-/*global define, $, WebSocket, FileError, XMLHttpRequest */
+/*jslint forin: true */
+/*global FileError */
 
  /**
  * Inspector manages the connection to Chrome/Chromium's remote debugger.