set eslints max-len to 120 #12780

Merged
merged 1 commit into from Sep 14, 2016

Projects

None yet

3 participants

@zaggino
Member
zaggino commented Sep 14, 2016

while 80 might be too narrow in some cases, anything over 120 means you have to scroll horizontally when reviewing pull requests on GH which is a real pain

cc @ficristo @petetnt

@petetnt
Member
petetnt commented Sep 14, 2016 edited

I am totally okay with this. Long lines are hard to follow, on GH editor as they are in Brackets.

Might be fixable with eslint --fix too if there's tons of lines spanning over 120 characters too.

@ficristo
Member

I'm okay too.

@zaggino zaggino merged commit f028b3e into master Sep 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zaggino zaggino deleted the zaggino/max-len branch Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment