-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Disabled context menu items for unsaved files #12806
Disabled context menu items for unsaved files #12806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM sans couple of missing pieces of JSDoc
MainViewManager = require("view/MainViewManager"), | ||
CommandManager = require("command/CommandManager"); | ||
|
||
function _setContextMenuItemsVisible(enabled, items) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs JSDoc
}); | ||
} | ||
|
||
function _setMenuItemsVisible() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs JSDoc
Thanks for this great PR @mansimarkaur! Tested against latest master and it works great. Could you add few small pieces of JSDoc for the new methods and maybe simple unit test for the functionality? ( 👍 |
@petetnt sure, I'll add the required changes. |
@petetnt Could you please help me with the tests? I was thinking of adding tests in the |
@mansimarkaur Any specific things you need help with the tests? The structure should could be something like:
For example check |
+1 big idea! |
This needs more work. Closing for now. |
LGTM sans tests, merging this and will open another issue for the tests as per #11763 (comment) Thanks for this great contribution @mansimarkaur and sorry for taking so long! PS: did this test totally flake? https://travis-ci.org/adobe/brackets/builds/206719157 CLA checked manually just in case. |
Fixes #11763