Product Backlog - Move Line Up/Down on Key #1282
Conversation
ghost
assigned 
|
@shadowcloud: this looks great, very thorough! I'll take a stab at reviewing this by early next week. |
| @@ -851,6 +851,8 @@ define(function (require, exports, module) { | |||
| menu.addMenuItem(Commands.EDIT_UNINDENT, [{key: "Unindent", displayKey: "Shift-Tab"}]); | |||
| menu.addMenuItem(Commands.EDIT_DUPLICATE, "Ctrl-D"); | |||
| menu.addMenuItem(Commands.EDIT_LINE_COMMENT, "Ctrl-/"); | |||
| menu.addMenuItem(Commands.EDIT_LINE_UP, {key: "Ctrl-Up", displayKey: "Ctrl-\u2191"}); | |||
| menu.addMenuItem(Commands.EDIT_LINE_DOWN, {key: "Ctrl-Down", displayKey: "Ctrl-\u2193"}); | |||
There was a problem hiding this comment.
The standard on Windows seems to be Ctrl+Shift+up/down (see Sublime, Notepad++, and IntelliJ/WebStorm). The only odd one out I could find is Eclipse, which uses Alt+up/down. On all of those editors, Ctrl+up/down instead scrolls the view by one line (without making any edits).
On Mac, most editors seem to lack this feature. Eclipse uses Alt+up/down, Sublime uses Cmd+Ctrl+up/down (edit: TextMate and Espresso also use this shortcut), and IntelliJ/WebStorm uses Cmd+Shift+up/down. I'd be inclined to go with Cmd+Shift since it's more consistent with the Windows shortcut (in fact Brackets will automatically convert Ctrl<->Cmd, so you wouldn't even have to declare two shortcuts in that case).
There was a problem hiding this comment.
Re the menus: move line up/down feels more related to Duplicate. In fact, now that this menu section is getting longer it feels weird to have Comment/Uncomment grouped in with more generic editing commands. How about reordering it so the menu looks like this?
...
Duplicate
Move Line(s) Up
Move Line(s) Down
---divider---
Comment/Uncomment Lines
---divider---
Use Tab Characters
There was a problem hiding this comment.
- In the details of the Products Backlog it was specified to use Ctrl+Up/Down as key bindings. So, I should do the following?
- Windows: Ctrl+Shift+Up/Down
- Mac: Alt+Up/Down
- I'll reorganize the menu as you've specified.
There was a problem hiding this comment.
Yes, I think the note in the backlog got this shortcut confused with the "scroll 1 line" feature that most editors have. Let's use Ctrl+Shift+up/down on Windows.
On Mac, I found that more of them support this than I thought. Sublime, TextMate and Espresso all use Cmd+Ctrl+up/down, so that seems like the best shortcut to use.
|
@shadowcloud: done reviewing. Please let me know what you think. And thanks again for this! It's always exciting to get a contribution including its own unit tests :-) |
| len = lines.length; | ||
|
|
||
| // place cursor at the beginning of the last line | ||
| myEditor.setCursorPos(len-1, 0); |
There was a problem hiding this comment.
JSLint nit: need spaces around the "-". Same thing with the last line of this function.
|
@shadowcloud: Thanks for your patience! Just a few more points to address before we merge this. |
|
@peterflynn: Everything should be in place as expected now, great code review. |
|
Great, looks good to go! Thanks again for the contribution -- hopefully the first of many ;-) |
Command to shift line(s) up/down
I've implemented the following functionality
https://trello.com/card/1-move-line-up-down-on-key/4f90a6d98f77505d7940ce88/487