This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Now search history is stored in state and can be traversed using arrow keys while focus is on search text #13237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he search history using key up and key down in search bar
…bh95/SearchHistory
zaggino
reviewed
Mar 27, 2017
src/search/FindBar.js
Outdated
| searchHistory.splice(searchQueryIndex, 1); | ||
| } else { | ||
| if (searchHistory.length === maxCount) { | ||
| searchHistory.splice(maxCount - 1, 1); |
There was a problem hiding this comment.
isn't .pop() the same thing?
zaggino
reviewed
Mar 27, 2017
src/search/FindBar.js
Outdated
| @@ -333,6 +346,15 @@ define(function (require, exports, module) { | |||
| // if Shift is held down). | |||
| self.trigger("doFind", e.shiftKey); | |||
| } | |||
| currentIndex = 0; | |||
| } else if (e.keyCode === KeyEvent.DOM_VK_DOWN) { | |||
| currentIndex = (currentIndex - 1 + Math.min(maxCount, searchHistory.length)) % Math.min(maxCount, searchHistory.length); | |||
zaggino
reviewed
Mar 27, 2017
src/search/FindBar.js
Outdated
| @@ -267,6 +267,7 @@ define(function (require, exports, module) { | |||
| FindBar._addFindBar(this); | |||
|
|
|||
| var $root = this._modalBar.getRoot(); | |||
| var currentIndex = 0; | |||
There was a problem hiding this comment.
I'd rename this to historyIndex or something little more specific
zaggino
reviewed
Mar 27, 2017
src/search/FindBar.js
Outdated
| $("#find-what").val(searchHistory[currentIndex]); | ||
| self.trigger("queryChange"); | ||
| } else if (e.keyCode === KeyEvent.DOM_VK_UP) { | ||
| currentIndex = (currentIndex + 1 + Math.min(maxCount, searchHistory.length)) % Math.min(maxCount, searchHistory.length); |
There was a problem hiding this comment.
can you wrap if (e.keyCode === KeyEvent.DOM_VK_DOWN) and if (e.keyCode === KeyEvent.DOM_VK_UP) { codes into a function taking an argument up or down? code seems to repeat itself
zaggino
approved these changes
Mar 28, 2017
swmitra
approved these changes
Mar 29, 2017
|
@saurabh95 Great job! This is a very handy feature for developers. Keep these coming... 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation doesn't have any UI as per this PR. We can have a discussion regarding its UI. There is also a trello card regarding the same with UI also https://trello.com/c/IzACddEv/344-s-find-recent-search-history .
Will have UI implementation(as per the discussion) in next PR.