Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Addresses #13264 where setting saveFoldStates preference to false caused folding problems #13269

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/extensions/default/CodeFolding/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,19 @@ define(function (require, exports, module) {
}

var saveFolds = prefs.getSetting("saveFoldStates");

if (!editor || !saveFolds) {
if (editor) {
editor._codeMirror._lineFolds = editor._codeMirror._lineFolds || {};
}
return;
}
var viewState = ViewStateManager.getViewState(editor.document.file);
var cm = editor._codeMirror;
var viewState = ViewStateManager.getViewState(editor.document.file);
var path = editor.document.file.fullPath;
var folds = cm._lineFolds || prefs.getFolds(path) || {};

//separate out selection folds from non-selection folds
var nonSelectionFolds = {}, selectionFolds = {}, range;
Object.keys(folds).forEach(function (line) {
Expand Down
8 changes: 8 additions & 0 deletions src/extensions/default/CodeFolding/unittests.js
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,14 @@ define(function (require, exports, module) {
var marks = getEditorFoldMarks();
expect(marks.length).toEqual(0);
});

runs(function () {
var lineNumbers = foldableLines;
var marks = getGutterFoldMarks();
var gutterNumbers = marks.filter(filterOpen)
.map(getLineNumber);
expect(gutterNumbers).toEqual(toZeroIndex(lineNumbers));
});
});

it("can set the minimum fold size", function () {
Expand Down