Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Replaced English comments with Japanese translations #13320

Closed
wants to merge 6 commits into from
Closed

Replaced English comments with Japanese translations #13320

wants to merge 6 commits into from

Conversation

Blackweda
Copy link
Contributor

This is a PR to fix issue #12880

This issue is fixing the comment sections for the French and Japanese translations so that the comments are in those respective languages, and not in English.

I looked over both:

samples/fr/Premiers pas
samples/ja/Getting Started

The French translation had already been done, so I worked out the translations for the Japanese and made the changes to the comment sections. If a more accurate translation comes up, please let me know.

This should close the issue if everyone is satisfied with the translations.

Here are the translation equivalents:

自分のファイルで始めましょう
Let’s start with your own file

Brackets のは何ですか
What is Brackets?

ご意見をお聞かせ
Tell us your opinion

HTML、CSSとJavaScriptとの関係
Relationship between HTML, CSS and JavaScript

<3とJAVASCRIPTで作成
Created with <3 and Javascript

ライブ プレビュー
Live preview

@Blackweda
Copy link
Contributor Author

I had a Japanese friend look over the translations. She only recommended a slight change to two of them because they sounded better to her when she read it that way. Everything else was fine with her.

@ficristo
Copy link
Collaborator

ficristo commented Apr 21, 2017

Usually Japanese translations are done by the Adobe team. I'm not sure about the samples...
@swmitra @saurabh95 ?

@Blackweda you should revert all the changes to the indentation of the closing -->.

@saurabh95
Copy link
Contributor

Yeah generally Adobe ALF team does translations, but we can definitely get this reviewed by them(since they would be having more context), and get it merged.
@VibhaMalhotra @ArturOledzki @pantkowiak @rajjain Could you please review this?

@Blackweda
Copy link
Contributor Author

sorry @ficristo , what are you saying about indentation of the closing --> ??
I didn't move anything except change the wording, the placement is still the same from beforehand.

@ficristo
Copy link
Collaborator

If you look at the GitHub interface you can notice some changes to lines with the closing -->.
It seems you accindentally convert some spacing to tabs, please undo that.

@Blackweda
Copy link
Contributor Author

Sorry I had deleted my forked version.. I have to redo all this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants