Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Changed Global.js to enable Native Menus for Linux #13339

Merged
merged 2 commits into from
May 3, 2017

Conversation

saurabh95
Copy link
Contributor

@saurabh95 saurabh95 commented Apr 26, 2017

We can merge this only after this adobe/brackets-shell#602 is merged.

Copy link
Collaborator

@swmitra swmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets wait for the shell PR to be merged.

@ficristo
Copy link
Collaborator

I think you can also remove this check:

if (brackets.inBrowser || brackets.platform === "linux") {

(and verify tests pass on Linux)

@saurabh95
Copy link
Contributor Author

@ficristo I have enabled Native Menu tests for Linux, they are passing 😄

@swmitra
Copy link
Collaborator

swmitra commented May 3, 2017

Merging now..
The dependency on Brackets shell is already resolved by merging adobe/brackets-shell#602.

@swmitra swmitra merged commit 5562adc into master May 3, 2017
@swmitra swmitra deleted the saurabh95/linux-native-menus branch May 3, 2017 06:20
@ficristo ficristo added this to the Release 1.10 milestone Jun 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants