Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update CSS Code Hints pseudo-selectors #13345

Merged
merged 2 commits into from
May 3, 2017
Merged

Update CSS Code Hints pseudo-selectors #13345

merged 2 commits into from
May 3, 2017

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Apr 28, 2017

Add pseudo-classes
:default
:dir()
:focus-within
:fullscreen
:indeterminate
:matches()
:placeholder-shown.

Add pseudo-element ::placeholder.

Fix alphabetical order, space around :.

Add pseudo-classes
– `:default`
– `:dir()`
– `:focus-within`
– `:indeterminate`
– `:matches()`
– `:placeholder-shown`.

Add pseudo-element `::placeholder`.

Fix alphabetical order, space around `:`.
@ficristo ficristo requested a review from swmitra May 2, 2017 17:49
"nth-last-of-type(n)": {"desc": "Selects every element that is the nth element of its parent, counting from the last child", "text":"nth-last-of-type()"},
"nth-of-type(n)": {"desc": "Selects every element that is the nth element of its parent", "text":"nth-of-type(n)"},
"only-of-type": {"desc": "Selects every element that is the only element of this type of its parent"},
"matches(selectors)": {"decs": "Selects every element that is matched by one or more selectors in the 'selectors' list"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the spelling of description key.

"nth-last-of-type(n)": {"desc": "Selects every element that is the nth element of its parent, counting from the last child", "text":"nth-last-of-type()"},
"nth-of-type(n)": {"desc": "Selects every element that is the nth element of its parent", "text":"nth-of-type(n)"},
"only-of-type": {"desc": "Selects every element that is the only element of this type of its parent"},
"matches(selectors)": {"decs": "Selects every element that is matched by one or more selectors in the 'selectors' list"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a 'text' field in the value with the insertion text as 'matches()'. Other wise user has to always delete selectors after hint selection.

@valtlai
Copy link
Contributor Author

valtlai commented May 3, 2017

@swmitra Fixed. Added :fullscreen

Copy link
Collaborator

@swmitra swmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swmitra
Copy link
Collaborator

swmitra commented May 3, 2017

@valtlai Good work. Waiting for more now...
Merging this PR.

@swmitra swmitra merged commit bc4fb9f into adobe:master May 3, 2017
@valtlai valtlai deleted the valtlai/css-pseudo branch May 3, 2017 16:18
@ficristo ficristo added this to the Release 1.10 milestone Jun 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants