Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix typos [Croatian] #13628

Merged
merged 1 commit into from Aug 22, 2017
Merged

Fix typos [Croatian] #13628

merged 1 commit into from Aug 22, 2017

Conversation

dbaric
Copy link
Contributor

@dbaric dbaric commented Aug 22, 2017

No description provided.

@dbaric
Copy link
Contributor Author

dbaric commented Aug 22, 2017

@petetnt I'd be pleased if you merged this pull request.

@petetnt petetnt changed the title typo (repost) Fix typos [Croatian] Aug 22, 2017
@petetnt
Copy link
Collaborator

petetnt commented Aug 22, 2017

Cool!

Tagging @diomed made changes last time. If you have the time to review these changes that would be neat!

@@ -62,7 +62,7 @@ define({
"ERROR_CREATING_FILE" : "Došlo je do greške prilikom pokušaja da se kreira {0} <span class='dialog-filename'>{1}</span>. {2}",

// Application preferences corrupt error strings
"ERROR_PREFS_CORRUPT_TITLE" : "Greška kod čitanja preferencija",
"ERROR_PREFS_CORRUPT_TITLE" : "Greška prilikom učitanja preferencija",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

učitavanja

Copy link
Contributor Author

@dbaric dbaric Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would need access to patch-1 branch in order to edit the commit. Can you do that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did u edit this in the first place? didn't you clone the repo? if you did, you should have that branch. that is your working branch. I hope u didn't delete it before merging.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really weird that the source shows unknown repository 🤔

Copy link
Contributor Author

@dbaric dbaric Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not clone it (there was no need) as I created commit directly via browser editor. If you can not edit the commit either I will repost.

Copy link
Contributor

@diomed diomed Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petetnt u can merge this, then fix that 1 word. I hope that's not a problem. Everything else is fine, and more in the spirit of Croatian language, I guess.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diomed This Brackets README page describes how to make updates to branches created directly in browser: https://github.com/adobe/brackets/tree/master/src/nls#updating-existing-branch-and-pull-request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@redmunds We have unknown repo instead of known fork path.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fork got destroyed at some point, but it's not a big deal. We can merge this and fix the one type in the next PR.

@petetnt
Copy link
Collaborator

petetnt commented Aug 22, 2017

Merging this, lets fix the leftover typo in another PR.

Thanks for your first contribution to adobe/brackets @dbaric!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants