move xorigin.js after css #14228
base: master
Are you sure you want to change the base?
move xorigin.js after css #14228
Conversation
Hi Phapdinh. Can you provide some data on the performance improvement gained with this change ? |
The change will cause a very slight performance improvement that is hard to measure. Moving the file down also helps with keeping the code organized and inline with the comments in the html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments to prevent us to start ignoring minor details in the project.
Hi @phapdinh. I suggest to squash commits into a single one. Merging too many commits for a simple change will make it difficult to track commits and changes later in the target branch. |
ca5b187
to
fbfa3e1
Compare
@saulotoledo I have squashed the five commits into 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phapdinh It is ok for me. I will keep the rest of the discussion with @vickramdhawal. :)
@navch What do you think about this PR? |
I am fine with this change. Just make sure this is not causing any problem. To confirm that we should run all unit tests and make sure there should not be any new error in the console because of this change. |
This improves page load performance as it moves the script tag for xorigin.js after css