Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fixing update notification locale issue, update notification was shown in English for all locales #14995

Merged
merged 2 commits into from Feb 12, 2020
Merged

Fixing update notification locale issue, update notification was shown in English for all locales #14995

merged 2 commits into from Feb 12, 2020

Conversation

g-217
Copy link
Contributor

@g-217 g-217 commented Dec 5, 2019

Removing pre-release specific code from release code, as it is causing update notification to be shown in English for all locales.
This will fix #14994

@g-217
Copy link
Contributor Author

g-217 commented Dec 6, 2019

@niteskum @swmitra @narayani28 please review.
@shubhsnov I have completed the changes.

@g-217 g-217 requested a review from shubhsnov December 16, 2019 07:14
Copy link
Collaborator

@swmitra swmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shubhsnov
Copy link
Collaborator

👍 LGTM

@narayani28 narayani28 merged commit 4374445 into adobe:master Feb 12, 2020
niteskum pushed a commit that referenced this pull request Mar 25, 2020
…-locale

Fixing update notification locale issue, update notification was shown in English for all locales
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPV] Update Notification not localized on WIN and MAC
5 participants