This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Refactor remotefunctions #1529
Merged
Refactor remotefunctions #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!EditAgent.isEditing) { | ||
| // only update the DOM if the change was not caused by the edit agent | ||
| Inspector.DOM.setNodeValue(node.nodeId, node.value); | ||
| } |
There was a problem hiding this comment.
To avoid changes that occur from the editor on the remote site to propagate back there, the DOMAgent must not push any changed node values if they have come from there (through the EditAgent).
ghost
assigned 
|
@jdiehl thanks again for submitting this. It's definitely something we want to get into master. I'm going to wait until after our Sept 24 milestone to review it and get it merged. (And, incidentally, after your Sept 19 milestone too...) |
|
Sorry it has taken so long to get to this request. I didn't test the experimental functionality, but I did verify that the non-experimental features still work. The code in RemoteFunctions.js is much cleaner now - thanks! Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a complete rewrite of RemoteFunctions.js that makes it more efficient and introduces a much better node editor.