This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Map key code for digit keys to the corresponding digits. #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cut with digit keys and Shift key will function correctly.
ghost
assigned 
|
reviewing |
| // If keycode represents one of the digit keys (0-9), then return the corresponding digit | ||
| // by subtracting KeyEvent.DOM_VK_0 from keycode. ie. [48-57] --> [0-9] | ||
| if (keycode >= KeyEvent.DOM_VK_0 && keycode <= KeyEvent.DOM_VK_9) { | ||
| return keycode - KeyEvent.DOM_VK_0; |
There was a problem hiding this comment.
We should explicitly return a string here: return Number(keycode - KeyEvent.DOM_VK_0).toString()
There was a problem hiding this comment.
I think you could also just do String(keycode - KeyEvent.DOM_VK_0)
|
Initial review complete |
|
Merging |
jasonsanjose
added a commit
that referenced
this pull request
Oct 2, 2012
Map key code for digit keys to the corresponding digits.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1745 for all keyboard layouts including French which has digit keys as shifted keys.