Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Implement statusbar UI and indentation controls #1766

Merged
merged 7 commits into from
Oct 4, 2012

Conversation

jasonsanjose
Copy link
Member

Requires focused editor fixes (issue #1257, pull #1765) to work properly.

Move EditorManager statusbar indicators from StatusBar module to EditorManager. Refactor HTML and LESS for statusbar styles. Note that indentation controls do not work yet.
@ghost ghost assigned redmunds Oct 4, 2012
@GarthDB
Copy link
Member

GarthDB commented Oct 4, 2012

Couple of changes:

  • Added title properties to the labels for tooltips explaining the toggle for spaces and tabs
  • On hover the spaces/tabs label should underline, but not the width number.

http://garthdb.github.com/Brackets-UI-Prototypes/status_bar/

@GarthDB
Copy link
Member

GarthDB commented Oct 4, 2012

Also, the currently implementation is slightly tighter than prototype, I would space it out a bit.

@jasonsanjose
Copy link
Member Author

Updated with tooltips, margins and hover changes.

@GarthDB
Copy link
Member

GarthDB commented Oct 4, 2012

looks good.

Couple more recommendations, sorry I didn't include them before

  1. In an attempt to make the arrows more clickable I added a pixel of padding on each side.
  2. The border top is a little dark on the status bar. The prototype uses border-top: 1px solid #E6E6E6;

<div id="indent-increment" class="indent-step"></div>
</div>
<div id="busy-indicator">&#9719;</div>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It bugs me that all of the info in the status bar is flowed into a line of text because every time and data changes, all info to the right (or left depending on which side) of whatever changed shifts a few pixels left or right. I would like to see the text layout using fixed width blocks so nothing ever ever shifts.

We could also try using Source Code Pro (monospace) font, but we'd have to pad leading spaces (i.e. so "1", "10", "100" all use same horizontal space).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #1772

@redmunds
Copy link
Contributor

redmunds commented Oct 4, 2012

Done with UI review. Still need to look at code.

@jasonsanjose
Copy link
Member Author

@GarthDB Changed border-top to darken @ step-size/2 percent. Added padding.

@jasonsanjose
Copy link
Member Author

Pushed fixes from initial UI review.

@redmunds
Copy link
Contributor

redmunds commented Oct 4, 2012

Looks good. Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants