Commits on Oct 18, 2012

1. Safer focusedEditorChanged event: …

   * Revert main-editor-swapping codepath back to how it used to work, mostly
   disentangled from focus events.
   * Don't fire focusedEditorChanged on the many times focus returns to the
   same Editor that had it last (due to window reactivation, closing a dialog,
   closing a search bar, etc.). All the current use cases for this event don't
   care about those cases. Add more detailed docs on event cases.
   * Simplify how Editor signals focus: trigger only from "onFocus" (a superset
   of the other case), and remove _internalFocus flag that was guarding against
   the overlap.
   * Don't call resizeEditor() on every editor swap just because statusbar
   *might* have been shown/hidden: only call when statusbar actually did
   change (going to/from no editor). Fixes scrolling issue in #1864.
   
   #1257 still isn't 100% fixed: there are at least two cases where getFocusedEditor()
   lags behind the focusedEditorChanged event: opening an inline editor; and
   moving focus from open inline editor to its host editor. These same cases -
   and a number of others - were broken before this change, however.

   

   peterflynn committed Oct 18, 2012
   Configuration menu

   • View commit details
   • Copy full SHA for 4a34b88
   • Browse repository at this point

   Copy the full SHA

   4a34b88 View commit details

   Browse the repository at this point in the history

2. Code review fix: focusedEditorChange was passing wrong last arg to its …

   listeners.
   And add a couple more docs.

   

   peterflynn committed Oct 18, 2012
   Configuration menu

   • View commit details
   • Copy full SHA for 9a2c59c
   • Browse repository at this point

   Copy the full SHA

   9a2c59c View commit details

   Browse the repository at this point in the history