Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Sidebar resize refactorization (2) #1908

Merged
merged 6 commits into from Oct 23, 2012
Merged

Sidebar resize refactorization (2) #1908

merged 6 commits into from Oct 23, 2012

Conversation

jbalsas
Copy link
Contributor

@jbalsas jbalsas commented Oct 21, 2012

This is the final step (hopefully) on the sidebar resize refactorization proposed initially in #1811 and developed in several steps in #1820, #1838 and #1899

It moves almost all the resize functionality for the sidebar into the utils/Resizer module.

Due to the last changes on flexbox, it also adds a new data-forcemargin to control the margins that need to be pushed while resizing an element.

@redmunds With a bit of luck this could be the end of the Resizer chapter for now ;)

@ghost ghost assigned redmunds Oct 21, 2012
@redmunds
Copy link
Contributor

In master, the area that shows the resize cursor is to the right of the panel edge, but in your branch it's too the left of the panel edge. Logically, I think it makes more sense to have the resize area over the panel that's being resized, but it causes a problem in this case because it's over the vertical scrollbar. It makes it difficult to grab the scrollbar with the mouse -- there's only 1-2 pixels where you can grab it.

@@ -40,8 +40,7 @@

<!-- Main UI -->
<div class="main-view">
<div id="sidebar-resizer"></div>
<div id="sidebar" class="sidebar quiet-scrollbars">
<div id="sidebar" class="sidebar quiet-scrollbars horz-resizable right-resizer collapsable" data-minsize="0" data-forcemargin=".content">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-click on collapsible areas is very cool, but please fix spelling :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops :)

@redmunds
Copy link
Contributor

Initial code review is complete. This cleans up a lot of code! Just a couple things to fix.

@jbalsas
Copy link
Contributor Author

jbalsas commented Oct 23, 2012

@redmunds On a side note, now that #1854 is fixed, I was thinking of adding a second pass (first one needs to stay on htmlReady to catch the sidebar size as soon as possible) in the Resizer on appReady. Hopefully it will be able to catch now the html resizer attributes for the extensions without the manual call to makeResizable. What do you think?

@redmunds
Copy link
Contributor

After reading the comments in #1854, I am not sure if it's fixed yet. Give it a try in a new branch, but I don't want these changes to wait on that.

Looks good. Merging.

redmunds added a commit that referenced this pull request Oct 23, 2012
@redmunds redmunds merged commit 0b04088 into adobe:master Oct 23, 2012
@jbalsas
Copy link
Contributor Author

jbalsas commented Oct 23, 2012

You're right... I guess I'll leave it to rest for a while then ;)

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants