This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Issue 1508 #1926
Merged
Issue 1508 #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thanks for fixing this. You're pretty close, but I still see the original issue and you need to make one more change I put in the line comment. |
| @@ -86,15 +86,15 @@ define(function (require, exports, module) { | |||
| lastSlash = path.slice(0, path.length - 1).lastIndexOf("/"); | |||
| } | |||
| if (lastSlash >= 0) { | |||
| rest = path.slice(0, lastSlash); | |||
| rest = " - " + path.slice(0, lastSlash); | |||
There was a problem hiding this comment.
You need to change it to rest = " - " + (lastSlash ? path.slice(0, lastSlash) : "/");
Otherwise, you won't see the slash after a project name that is using one of the root folders in your Mac Volumes. ie. the original issue is not fixed yet, but the other issue of having the mac volume as your project folder is fixed.
|
Done with initial review. |
|
Thanks. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the recent projects dropdown, it will now just show "/" (with no "-" after it) if you select the entire hard-drive in OSX. Same thing for the current project.