This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix Delete Line to avoid exceptions and work intuitively in inline editors #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itors. Add unit tests.
ghost
assigned 
| if (this._visibleRange.startLine === null || this._visibleRange.endLine === null) { | ||
| throw new Error("ERROR: Typing in Editor should not destroy its own _visibleRange"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Removing this seems reasonable to me. InlineEditorProviders-test contains a solid suite of tests ("Inline Editor range updating") that make sure inline editors don't lose sync and close at the wrong times, and at least a few tests that also cover Document-Editor syncing.
|
@njx: done reviewing. Great thorough set of tests, btw. |
… sync in unit tests.
|
Ready for re-review. |
|
Looks good with those changes -- merging |
peterflynn
added a commit
that referenced
this pull request
Oct 26, 2012
Fix Delete Line to avoid exceptions and work intuitively in inline editors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1764, removed the exception on losing visible range during edits, and tweaked Delete Line so that it always remains within visible range boundaries.
Also adds unit tests for Delete Line (there weren't any before).
@peterflynn, would you mind taking a look?