This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
removeMenuItem() API #2072
Merged
removeMenuItem() API #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto pflynn/remove-menuitem * 'removeMenuItem' of https://github.com/tpryan/brackets: Renaming variable to make it, you know, refer to what it actually is. Testing for proper handling of junk being thrown into the removeMenuItem function. Added exception handling for cases where someone throws junk into the function Adding test to verify that removing by command or commandID string would work. Removing Extraneous DIVIDER code Cleaning out some whitespace from my addition to the test. Fixed remove menu item to remove the parent <li> of the <a> link that contains it. Added ability to accept commands as well as id's. Fixing comment grammar mistake. Made changes to code in line with @peterflyn feedback here: #1193 Checking in the addition of RemoveMenuItem. Also made file pass jslint. Conflicts: test/spec/Menu-test.js
…tests in spec share one window (use unique ids for everything). Code cleanup in removeMenuItem(): use existing utility method to compute menu item id. Plus some docs tweaks.
Closed
|
I realized after the fact that relocating the unit tests within the file makes it hard to diff my changes vs. the original (to see the part that hasn't been code reviewed already). But you can always copy-paste the two ranges from: |
|
Looks fine, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new Menu API for removing existing menu items.
This is just polishing off an existing patch from @tpryan, #1193. The additional changes here are: