-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Go to the most recently visited file when closing a file #2122
Conversation
This works great, but it seems to duplicate the logic that's already in the getNextPrevFile() function. Can you just call that function instead? |
Done with initial review. |
Done. Totally missed that function there. Had to move it up to use it just to pass JSLint. |
This works great in this case:
Result: it switches back to file previously being edited in working set But it's not working in this case:
Result: I haven't figured out the pattern, but in most cases it does not re-select the file being edited in step 2. Note that there are several ways to close a file in Brackets, so be sure to test all of these:
|
Not sure how I missed this. I did tested and worked, maybe the code wasn't fully updated. But this time it does work in all the cases. |
Looks good. Merging. |
Go to the most recently visited file when closing a file
…e last file in the working set, getNextPrevFile()'s semantics aren't a perfect match for what we want. Need a special case.
This would add what was suggested in #2091