This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Update to latest CodeMirror upstream master #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update SHA to our CodeMirror fork's master, which is now clean with upstream (brackets-sprint20 branch in the adobe/CodeMirror2 fork is no longer needed) - Fix htmlmixed mode to specify parameters for handling mustache/handlebars templates, as required by latest CodeMirror - Reinstate commented-out unit tests from #2887 since the underlying CM bug should now be fixed
ghost
assigned 
|
@njx htmlmixed update looks good. |
|
@njx Is there more reviewing that you want done, or should I merge it? |
|
No, I think you can just merge (the only other change is the uncommenting-out of a couple of EditorCommandHandlers unit tests--feel free to run them to make sure they work on your machine :), but if not jenkins will catch it). |
redmunds
added a commit
that referenced
this pull request
Feb 19, 2013
Update to latest CodeMirror upstream master
This was referenced Sep 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(brackets-sprint20 branch in the adobe/CodeMirror2 fork is no longer needed)
templates, as required by latest CodeMirror
should now be fixed
@redmunds - assigning to you to review the htmlmixed update.