This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
A few improvements fixes in Recent Projects #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| * @param {string} path The full path to the folder. | ||
| * @return {{path: string, folder: string, rest: string}} | ||
| */ | ||
| function renderPath(path) { |
There was a problem hiding this comment.
Since this is no longer actually rendering anything, we should rename it to something like parsePath().
There was a problem hiding this comment.
(and update the comment description)
|
Great cleanup! Just a couple minor suggestions--once you've addressed them, feel free to go ahead and merge. Thanks. |
|
Great. Fixed pushes, so I'll merge it. If there is any other problem I can address it in another request :) |
TomMalbran
added a commit
that referenced
this pull request
Apr 6, 2013
…ents A few improvements fixes in Recent Projects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few changes to the Recent Projects extension: