Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Add link to google JSLint Error #3227

Closed
wants to merge 1 commit into from
Closed

Add link to google JSLint Error #3227

wants to merge 1 commit into from

Conversation

drewhamlett
Copy link
Contributor

#3131

May need a little more discussion completing the issue but this is a start.

@redmunds
Copy link
Contributor

FYI, the JSLint functionality is currently be re-factored out of Brackets core and into an extension in pull request #3143, so this change will have to be co-ordinated with that one.

@DennisKehrig
Copy link
Contributor

Looks like this would be easy to re-integrate after #3143 has landed, just modify extensions/default/JSLint/main.js as you modified language/JSLintUtils.js now.

@TomMalbran
Copy link
Contributor

Not completely the same, since the new extension uses a template and event delegation, so the link should be added to the template and the event, can be added as if inside the click event on the table (you can get the reason from the table content) or one event for each link.

I think that Search instead of Google might be better and could be added to the strings. Anyway, a better solution to #3131 might be just to add:

cursor: auto;
-webkit-user-select: text;
-khtml-user-select: text;
-moz-user-select: text;
-ms-user-select: text;
-o-user-select: text;
user-select: text;

To each cell, in the css inside the extension.

@drewhamlett
Copy link
Contributor Author

@TomMalbran The user-select mode may not work like you would expect in this situation. It may need a little more thought if you do something like that. That's what I was originally had, but someone on chat suggested the auto search. Can't remember his name though.

I like the template and event binding. After using angular js for so long it felt so wrong(and weird) adding that little bit of code and click event. Haha

@TomMalbran
Copy link
Contributor

You are right, I tested it and it didn't work, not sure why thought. I guess that a search isn't that bad then, it is even what you usually want to do when copying it anyway.

Most of this jQuery things were done before adding Mustache as the template system, and where not changed. I also find it wrong to be making a whole template like this, so I've been changing most to use Mustache instead.

@DennisKehrig
Copy link
Contributor

#3143 is in, so this could now be revisited

@drewhamlett
Copy link
Contributor Author

#3304

@adrocknaphobia
Copy link
Contributor

FYI. We may want to consider linking to this site (or pulling in their data).
http://jslinterrors.com

@njx
Copy link
Contributor

njx commented Apr 16, 2013

Closing -- looks like #3304 supersedes this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants