This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix #3228: Codehints selection popup is positioned wrong when the font size is not standard #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good so far, |
|
Your welcome. I did lots of testing to figure out what were the random numbers from before and to make it look good, knowing why it did. It actually even snaps better when the hints go on top of the cursor too. |
ghost
assigned 
|
Assign to myself. Reviewing... |
|
Looks great! Merging |
jbalsas
added a commit
that referenced
this pull request
Mar 29, 2013
Fix #3228: Codehints selection popup is positioned wrong when the font size is not standard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #3228, making code hint use the text height when positioning the hinting menu.