Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Issue #3131 - Making JSLint errors copyable #3688

Merged
merged 2 commits into from
May 10, 2013
Merged

Issue #3131 - Making JSLint errors copyable #3688

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c99847f
Issue #3131 - Making JSLint errors copyable
May 1, 2013
97d737c
Fix code review issues.
May 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/extensions/default/JSLint/htmlContent/bottom-panel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div id="jslint-results" class="bottom-panel vert-resizable top-resizer no-focus">
<div id="jslint-results" class="bottom-panel vert-resizable top-resizer">
<div class="toolbar simple-toolbar-layout">
<div class="title">{{JSLINT_ERRORS}}</div>
</div>
Expand Down
7 changes: 1 addition & 6 deletions src/extensions/default/WebPlatformDocs/WebPlatformDocs.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,7 @@

/* Enable text selection */
cursor: auto;
-webkit-user-select: text;
-khtml-user-select: text;
-moz-user-select: text;
-ms-user-select: text;
-o-user-select: text;
user-select: text;
.user-select(text);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extension, and most others, do not include brackets_mixins.less, and do not have access to your new mixin, so this change needs to be backed out.


&:focus {
outline: none;
Expand Down
12 changes: 6 additions & 6 deletions src/styles/brackets.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,7 @@ html, body {
overflow: hidden;

/* Turn off selection for UI elements */
-webkit-user-select: none;
-khtml-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
-o-user-select: none;
user-select: none;
.user-select(none);

/* And make sure we get a pointer cursor even over text */
cursor: default;
Expand Down Expand Up @@ -839,3 +834,8 @@ li.smart_autocomplete_highlight {
background-size: 100%;
}
}

/* Turn on text selection for JSLint error messages */
#jslint-results {
.user-select(text);
}
10 changes: 10 additions & 0 deletions src/styles/brackets_mixins.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,13 @@
-o-transform-origin: @horizontal @vertical;
transform-origin: @horizontal @vertical;
}

/* Change the settings for user-select and its counterparts, defaulting to none. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice mixin!

.user-select(@type: none) {
-webkit-user-select: @type;
-khtml-user-select: @type;
-moz-user-select: @type;
-ms-user-select: @type;
-o-user-select: @type;
user-select: @type;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please add an empty line to end of file

14 changes: 2 additions & 12 deletions src/styles/brackets_patterns_override.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,12 +441,7 @@

// Enable text selection
cursor: auto;
-webkit-user-select: text;
-khtml-user-select: text;
-moz-user-select: text;
-ms-user-select: text;
-o-user-select: text;
user-select: text;
.user-select(text);
}
}
}
Expand Down Expand Up @@ -563,12 +558,7 @@

// Enable text selection
cursor: auto;
-webkit-user-select: text;
-khtml-user-select: text;
-moz-user-select: text;
-ms-user-select: text;
-o-user-select: text;
user-select: text;
.user-select(text);
}
}

Expand Down