This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
[CRAZY] CSS font-family hints #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 15, 2013 16:04
… to indicate that the current session should be closed, but that the CHM should immediately attempt to begin a new session.
…rom property names to values to give other more specialized hinters (like EWF) a chance to intervene.
ghost
assigned 
|
This addresses adobe/brackets-edge-web-fonts#69 and adobe/brackets-edge-web-fonts#104. |
|
Looks good. I verify that your crazy idea does work. Merging. |
RaymondLim
added a commit
that referenced
this pull request
May 18, 2013
[CRAZY] CSS font-family hints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes three changes, the first of which is ostensibly innocuous while the latter two of which are probably crazy:
CSSProperties.jsonso that the CSS hinter can provide font-family hints. This is useful because EWF might not be installed, might have failed to load, etc.trueto signal this in addition to all of their previous options,null, a hint object, or a deferred hint object, for which the semantics have not changed.font-family:then upon typing the:the provider returnstrue, hence requesting that the session be restarted. If a higher-priority provider is registered (like, e.g., EWF) then it can take over. Without this change, higher priority providers wouldn't get the opportunity to take over until the lower-priority provider ended the session because it either ran out of hints to provide (which is not the case here) or it inserted a hint (which also wouldn't happen here if the user typed outfont-familyin full).Discuss!