Fix for Issue 4265: Mac: KeyBindingManager displays errant error message

[WebsiteDeveloper]

@redmunds #4265

[jasonsanjose]

insert space after if

[jasonsanjose]

@WebsiteDeveloper I tested this on mac and still saw the error. I believe it's because we still attempt to add all key bindings, not just the first one that matches. We might want to update addBinding at line 567 with

keyBindings.some(function addSingleBinding(keyBindingRequest) {
    // attempt to add keybinding
    keyBinding = _addBinding(commandID, keyBindingRequest, keyBindingRequest.platform);

    if (keyBinding) {
        results.push(keyBinding);
        return true;
    }

    return false;
});

Initial review complete

[WebsiteDeveloper]

@jasonsanjose added it and it should fix the problem.

[jasonsanjose]

I'm seeing the wrong shortcuts appear on mac (e.g. F3 for find next). I tried fixing the sort function and this seems to work. I think you have your sort logic backwards:

keyBindings.sort(function (a, b) {
    if (a.platform === brackets.platform) {
        // "a" is platform specific and matches
        return -1;
    } else if (b.platform === brackets.platform) {
        // "b" is platform specific and matches
        return 1;
    } else if (!a.platform && b.platform) {
        // "a" is generic and "b" is not matching
        return -1;
    } else if (!b.platform && a.platform) {
        // "b" is generic and "a" is not matching
        return 1;
    } else {
        return 0;
    }
});

[jasonsanjose]

Reviewed again. Back to @WebsiteDeveloper

[WebsiteDeveloper]

@jasonsanjose pushed the changes.
by the way what about the boss option? is it still necessary?

[jasonsanjose]

@WebsiteDeveloper thanks for the reminder. I'll do that separately. Merging.