[OPEN] Update Less to 1.4.2 #4476

WebsiteDeveloper · 2013-07-16T16:28:52Z

No description provided.

gruehle · 2013-07-17T20:10:33Z

src/styles/brackets_shared.less

@@ -40,23 +40,23 @@
 /* LESS imports */

 // Bootstrap @ v.2.3.1
-@import url(bootstrap/bootstrap.less);
+@import "bootstrap/bootstrap.less";


Removing url() doesn't seem necessary. Why was that change made?

because a crash happened when not removing url().

Interesting.. I tried removing url() and everything worked fine for me. I also updated the branch to the latest master, so I'm not sure if that made a difference or not.

for me there seemed to happen some kind of parse error in less.

Where are you seeing the error? I switched back to using url() and I don't see any problems. If you are still seeing problems, can you try using both url() and quotes? For example:

@import url("bootstrap/bootstrap.less");

Are you at the latest version of master? We upgraded CEF recently (in Sprint 31), so maybe that's the difference.

I just rebuilt my shell with the latest code to be sure, but the crash still happens.

In my opinion this has to do with how less resolves the relative paths which could also be the reason for the unit test failure.

You could try either the rootpath or relativeUrls options described here: http://lesscss.org/#usage

Otherwise, file an issue with LESS. I'm sure they'd like to hear about it and may even provide a workaround.

With url and quotes it works but without i get a parse error.

I missed this statement you made above. If it works with both url() and quotes, then make that change and I am OK with it.

gruehle · 2013-07-17T20:18:44Z

@WebsiteDeveloper Thanks. Are you aware of any bugs in 1.4.1? I did some quick sanity testing with your branch and everything seemed okay.

WebsiteDeveloper · 2013-07-17T21:11:16Z

@gruehle i am currently not aware of any bugs in 1.4.1. Actually i have been working with this branch a few days and didn't notice any bugs yet.

TuckerWhitehouse · 2013-07-17T23:13:18Z

I've also been using the less 1.4.1 compiler for the past few days and haven't noticed any issues.

On another note, If you enabled the "strictMath" mode (which will be enabled by default in the future), the UI loads, but the sidebar is rather broken...

WebsiteDeveloper · 2013-07-18T05:30:15Z

@TuckerWhitehouse i think i'll look into that and open another subsequent pull request

WebsiteDeveloper · 2013-07-31T18:17:03Z

@gruehle any news on this?

gruehle · 2013-08-04T00:47:01Z

@WebsiteDeveloper - Sorry, I've been out on vacation this week, and will be out next week, too. I'm going to tag this as [OPEN] to see if someone else can get this merged in before I return.

WebsiteDeveloper · 2013-08-04T06:48:41Z

@gruehle no problem :) enjoy your vacation.

WebsiteDeveloper · 2013-09-01T08:33:31Z

@gruehle are you in again?

redmunds · 2013-09-03T14:44:37Z

@WebsiteDeveloper I can take a look at this one.

redmunds · 2013-09-03T21:31:07Z

@WebsiteDeveloper I'm ready to review this one -- can you merge the latest master into your branch?

WebsiteDeveloper · 2013-09-04T06:08:11Z

@redmunds merged with master.

redmunds · 2013-09-04T18:54:23Z

This unit test is failing: Integration > Extension Utils > "should attach LESS style sheets":

Error: Expected '/* basic.less */
#project-title {
  font-size: 66px;
}
' to be '/* basic.less */
#project-title {
  font-weight: 800;
}
#project-title {
  font-size: 66px;
}
'.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toBe (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/spec/ExtensionUtils-test.js:134:40)
    at jasmine.Block.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at onComplete (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1838:18)
    at jasmine.WaitsForBlock.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2322:5)
    at file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2336:12

redmunds · 2013-09-04T19:13:05Z

Done with initial review.

WebsiteDeveloper · 2013-09-06T12:03:08Z

@redmunds by the way if i put an url around the current import line in basic.less.
like that url("sub dir/fourth.less"); the unit test don't fail anymore. This is very weird actually.

WebsiteDeveloper · 2013-09-07T06:44:48Z

@redmunds i pushed a few changes.

TomMalbran · 2013-09-07T17:14:28Z

@WebsiteDeveloper It looks like tou still need to merge with master and fix the conflict issues.

WebsiteDeveloper · 2013-09-07T18:13:25Z

@TomMalbran will do so thanks for the heads up.

WebsiteDeveloper · 2013-09-07T18:17:51Z

@redmunds @TomMalbran fixed merge conflict.

redmunds · 2013-09-08T00:45:34Z

@WebsiteDeveloper This is looking good, but there's a unit test failing in this branch that's not failing in master. Maybe just need to sync with master again?

Unit > HighlightAgent > "should toggle the highlight via a command"

Error: Expected spy showHighlight to have been called.
    at new jasmine.ExpectationResult (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:102:32)
    at null.toHaveBeenCalled (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1194:29)
    at null.<anonymous> (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/spec/LiveDevelopment-test.js:299:65)
    at jasmine.Block.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1024:15)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at jasmine.Queue.start (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1795:8)
    at jasmine.Spec.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2122:14)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)
    at jasmine.Queue.start (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1795:8)
    at jasmine.Suite.execute (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:2267:14)
    at jasmine.Queue.next_ (file:///C:/Users/redmunds/github/brackets-shell/Release/dev/test/thirdparty/jasmine-core/jasmine.js:1842:31)

WebsiteDeveloper · 2013-09-09T12:35:50Z

@redmunds i couldn't figure it out until now. Just wanted to lett you know that i will be away until next week.
Maybe you can figure out whats the matter with the unit test, if you have some spare time ;)

redmunds · 2013-09-11T23:20:58Z

@WebsiteDeveloper I'm hoping that is fixed with pull request #5115, so try merging with latest master code before spending any time on it.

WebsiteDeveloper · 2013-09-15T09:55:43Z

@redmunds i fixed the unit test failure. this one just failed because less wasn't correctly included.

redmunds · 2013-09-15T16:49:35Z

@WebsiteDeveloper I'm also noticing a reference to 'src/thirdparty/less-1.3.3.min.js' in brackets/Gruntfile.js that needs to be updated. Thanks.

WebsiteDeveloper · 2013-09-15T19:53:41Z

@redmunds changes pushed.

redmunds · 2013-09-16T14:30:17Z

Thanks! Merging.

[OPEN] Update Less to 1.4.2

Update Less to 1.4.1

55defb5

ghost assigned gruehle Jul 16, 2013

gruehle reviewed Jul 17, 2013
View reviewed changes

WebsiteDeveloper added 2 commits July 31, 2013 21:16

Merge branch 'master' into less-upgrade

14c5c2f

Fixed a few issues with strict math mode

31ba80c

ghost assigned redmunds Sep 1, 2013

Merged with master

28e5f20

Update to less 1.4.2 and fix unit tests and use url()

4ef5752

Merged with master

4ea4a12

WebsiteDeveloper added 2 commits September 15, 2013 11:30

Merge remote-tracking branch 'origin/master' into less-upgrade

6d2c461

Fix unit test failure

97e3986

change gruntfile

54cfd80

redmunds added a commit that referenced this pull request Sep 16, 2013

Merge pull request #4476 from WebsiteDeveloper/less-upgrade

939d97f

[OPEN] Update Less to 1.4.2

redmunds merged commit 939d97f into adobe:master Sep 16, 2013

WebsiteDeveloper deleted the less-upgrade branch February 1, 2014 16:05

core-ai-bot mentioned this pull request Aug 29, 2021

[CLOSED] [OPEN] Update Less to 1.4.2 brackets-archive/bracketsIssues#4146

Open

[OPEN] Update Less to 1.4.2 #4476

[OPEN] Update Less to 1.4.2 #4476

Conversation

WebsiteDeveloper commented Jul 16, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gruehle commented Jul 17, 2013

WebsiteDeveloper commented Jul 17, 2013

TuckerWhitehouse commented Jul 17, 2013

WebsiteDeveloper commented Jul 18, 2013

WebsiteDeveloper commented Jul 31, 2013

gruehle commented Aug 4, 2013

WebsiteDeveloper commented Aug 4, 2013

WebsiteDeveloper commented Sep 1, 2013

redmunds commented Sep 3, 2013

redmunds commented Sep 3, 2013

WebsiteDeveloper commented Sep 4, 2013

redmunds commented Sep 4, 2013

redmunds commented Sep 4, 2013

WebsiteDeveloper commented Sep 6, 2013

WebsiteDeveloper commented Sep 7, 2013

TomMalbran commented Sep 7, 2013

WebsiteDeveloper commented Sep 7, 2013

WebsiteDeveloper commented Sep 7, 2013

redmunds commented Sep 8, 2013

WebsiteDeveloper commented Sep 9, 2013

redmunds commented Sep 11, 2013

WebsiteDeveloper commented Sep 15, 2013

redmunds commented Sep 15, 2013

WebsiteDeveloper commented Sep 15, 2013

redmunds commented Sep 16, 2013