This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Highlight the full active line and only hightlight in the focused editor #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| background: @activeline-bgcolor; | ||
| } | ||
| .CodeMirror-focused .CodeMirror-activeline .CodeMirror-gutter-elt { | ||
| background: @activeline-bgcolor; |
There was a problem hiding this comment.
Line number gets the @activeline-bgcolor only for unwrapped lines. If Word Wrap is on, gutter areas for the extra lines wrapped from the original line do not have the active line color.
|
Done initial review. Looks good except for gutter area of wrapped lines. |
|
Nice catch. Fixed it. Might be a hacky way, but it seems to be the only way and it works. I had to make the gutter element use all the available height to fix the background. |
RaymondLim
added a commit
that referenced
this pull request
Aug 22, 2013
Highlight the full active line and only hightlight in the focused editor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "extend active line highlight to include line numbers" part of the issue #3191.
I also noticed a regression where the active line appeared on both main editor and inline editor, probably after the removal of some !important on the highlight rules, so I fixed this too without using !important.