This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Implement rule list widget #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor InlineEditor into 2 classes: InlineEditor (generic inline) and InlineTextEditor (inline with one or more text editors) * Add rule list UI for displaying multiple selector matches * Rename properties InlineEditor.onClosed and onParentShown to match Editor argument names * Update styling based on prototype
* Fix inheritance in InlineEditor constructors * Restore event handler names * Fix dirty indicator handling
|
reviewing |
| CSSInlineEditor.prototype.load = function (hostEditor) { | ||
| this.hostEditor = hostEditor; | ||
|
|
||
| InlineTextEditor.prototype.load.call(this, hostEditor); |
There was a problem hiding this comment.
If you define add the following to CSSInlineEditor:
CSSInlineEditor.prototype.parentObject = InlineTextEditor.prototype;
then you can call load() this way
this.parentObject.load.call(this, hostEdtior);
I read about this technique here: http://phrogz.net/js/classes/OOPinJS2.html
I suspect with these classes we may be overriding functionality a lot and wanting to call super, so it may be good to not explicitly put the parent class in the function calling code in case we add more to the inheritance hierarchy later
|
Done with review. I really like the refactoring of InlineEditor and InlineTextEditor. The chrome looks great too! |
|
Pushed fixes |
tvoliter
added a commit
that referenced
this pull request
Mar 29, 2012
merging in rule list widget code
This was referenced Aug 11, 2020
This was referenced Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tvoliter