This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Make code hint insertion on tab key configurable #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mine whether or not the currently selected hint should be inserted on tab key events
| * setInsertHintOnTab(true) indicates that the currently selected code hint | ||
| * should be inserted on tab key events. setInsertHintOnTab(false) indicates | ||
| * that a tab character should be inserted into the editor on tab key events. | ||
| * The default behavior can be can be overridden by individual providers. |
There was a problem hiding this comment.
Duplicate "can be" on this line.
ghost
assigned 
|
Done initial review. just 2 minor nits. |
|
I fixed both of these issues, so this is ready for re-review. Thanks for the quick turnaround! |
|
@iwehrman Seems like you haven't pushed your commit yet. |
|
Whoops again. Sorry about that. Commits are pushed now. |
|
Looks good... Merging. |
RaymondLim
added a commit
that referenced
this pull request
Sep 6, 2013
Make code hint insertion on tab key configurable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4963 by making the behavior of the
CodeHintListon tab key events configurable on a global and per-CodeHintProviderbasis. TheCodeHintManagerprovider registration API is generalized with an additional optional property,insertHintOnTab, that indicates whether theCodeHintManagershould request that the provider of the current session insert the currently selected hint on tab key events, or if instead a tab character should be inserted into the editor. If a provider omits this property, the behavior is determined by theCodeHintManager. The default behavior is to insert a tab character into the editor, as is the case now. The default can be changed globally with the newCodeHintManager.setInsertHintOnTab(bool)method. For an example use of this method, see my awesome new extension: iwehrman/brackets-insert-hint-on-tab.This was @peterflynn's idea!