Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Added Serbian translation #5515

Merged
merged 5 commits into from
Oct 25, 2013
Merged

Added Serbian translation #5515

merged 5 commits into from
Oct 25, 2013

Conversation

goranvasic
Copy link
Contributor

Added Serbian translation: "sr" folder with 2 new files, strings-app.js and string.js, and modified strings.js in nls folder so that this language is listed

@Knele83
Copy link

Knele83 commented Oct 15, 2013

Date: Mon, 14 Oct 2013 16:49:30 -0700
From: notifications@github.com
To: brackets@noreply.github.com
Subject: [brackets] Added Serbian translation (#5515)

Added Serbian translation: "sr" folder with 2 new files, strings-app.js and string.js, and modified strings.js in nls folder so that this language is listed

You can merge this Pull Request by running
git pull https://github.com/Gocilla/brackets master
Or view, comment on, or merge it at:

#5515

Commit Summary

Added Serbian translation

File Changes

A
src/nls/sr/strings-app.js
(30)


A
src/nls/sr/strings.js
(480)


M
src/nls/strings.js
(3)

Patch Links:

https://github.com/adobe/brackets/pull/5515.patch
https://github.com/adobe/brackets/pull/5515.diff

@jbalsas
Copy link
Contributor

jbalsas commented Oct 15, 2013

@gocilla, thanks a lot for contributing!

Before we can accept this, we'll need you to sign the Brackets Contributor License Agreement. You only need to do this once.

Also, we usually try to have another native speaker to do a peer review of the translation. Do you know someone who would be willing to do that? We'll ask around otherwise :)

@goranvasic
Copy link
Contributor Author

You're welcome, I have signed the Brackets Contributor License Agreement. As for the peer reviewing part, I am new to GitHub so I currently do not know anyone who could help with that.

@ghost ghost assigned couzteau Oct 15, 2013

// Application error strings
"ERROR_IN_BROWSER_TITLE" : "Упс! \"{APP_NAME}\" још увек не ради у претраживачу.",
"ERROR_IN_BROWSER" : "Апликација \"{APP_NAME}\" је направљена помоћу HTML-а, али тренутно ради као \"desktop\" апликација па је можете користити за измену локалних датотека. Молимо Вас користите \"application shell\" на <b>github.com/adobe/brackets-shell</b> репозиторијумз за покретање \"{APP_NAME}\" апликације.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo on this line, "репозиторијумз" should be "репозиторијум".

@goranvasic
Copy link
Contributor Author

Thanks @frennky for your review, I changed these typos as you suggested.

@goranvasic
Copy link
Contributor Author

Hello @jbalsas, I see that this CI build has failed because of a gateway timeout error, so are there any further actions required from my side?

@redmunds
Copy link
Contributor

Click on the Details link in the Travis error message and read details to see if there's a real problem. If not, you can restart the build from that page.

@goranvasic
Copy link
Contributor Author

@redmunds I had to push another commit since I was not able to figure out how to rerun the build, and now the CI build passed (I guess I needed admin rights to restart previous build). But basically, as I wrote earlier, CI build failed because of a gateway timeout error (HTTP Error 504), there was not any real problem to fix.

@couzteau
Copy link
Member

Travis passed. Changes approved by @frennky. Good to merge.

couzteau added a commit that referenced this pull request Oct 25, 2013
Added Serbian translation
@couzteau couzteau merged commit 62f7028 into adobe:master Oct 25, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants