This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Provide i18n for InlineBezierCurveEditor #5553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
added 2 commits
October 18, 2013 15:08
|
|
||
| InlineBezierCurveEditor = require("InlineBezierCurveEditor").InlineBezierCurveEditor, | ||
| BezierCurveUtils = require("BezierCurveUtils"); | ||
| BezierCurveUtils = require("BezierCurveUtils"), | ||
| EmbeddedStyles = require("text!EmbeddedStyles.css"); |
There was a problem hiding this comment.
Name of new css file should have better description -- something like localized.css.
There was a problem hiding this comment.
But maybe we want to add some more CSS rules later, wo this is a general name for the file.
But I can rename it if you still want to.
There was a problem hiding this comment.
There's already main.css for general rules. This new css file is only for localized content and the name should reflect that to help prevent other rules from getting put in it.
|
@SAplayer Brilliant! Done with code review. |
|
Just done the rename. Hope it's ready for merging now. |
|
Thanks. Merging. |
redmunds
added a commit
that referenced
this pull request
Oct 18, 2013
Provide i18n for InlineBezierCurveEditor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a translation (currently english + german) for the InlineBezierCurveEditor which was introduced with #5550.
CC @redmunds
Check german translation: @ingorichter @couzteau @pthiess