Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fire selectionChanged when working set is modified #720

Merged
merged 3 commits into from Apr 25, 2012

Conversation

jasonsanjose
Copy link
Member

Fix for #719

@redmunds
Copy link
Contributor

reviewing

@redmunds
Copy link
Contributor

Here's another case:

  1. Open a subfolder and select one of its files.
  2. Verify selection triangle is shown.
  3. Close subfolder

Results: Selection triangle is continued to be displayed on the same line, so it's pointing at whatever file/folder randomly gets drawn on that line.

So, event also needs to get fired when project tree is updated.

@redmunds
Copy link
Contributor

The other scenario I noticed is this:

  1. Search on something using Find in Files
  2. Click on a result in the list that is not in the Working Set
  3. Verify file is displayed in editor

Results: The file is usually selected in the project folder, but not always. I haven't nailed down a pattern, so it seems intermittant. Also, is seems a bit slow when file is down a subfolder or 2 (which is as deep as I tested).

@jasonsanjose
Copy link
Member Author

The bug about the project tree not showing find results exists in master. I'm pretty sure this doesn't have to do with the selection triangle changes.

This is intermittent based on how deep the tree is already loaded since we only load tree nodes on-demand.

redmunds added a commit that referenced this pull request Apr 25, 2012
Fire selectionChanged when working set is modified
@redmunds redmunds merged commit 63503ad into master Apr 25, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants