Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Copyright update #742

Merged
merged 9 commits into from Apr 26, 2012
Merged

Copyright update #742

merged 9 commits into from Apr 26, 2012

Conversation

pthiess
Copy link
Contributor

@pthiess pthiess commented Apr 25, 2012

Updated Copyright notice - please review and make sure that I didn't miss files which should have our copyright and that I didn't put copyright on files not created by us.

@peterflynn
Copy link
Member

I'm not the official reviewer, but three quick comments:

src/LiveDevelopment/Inspector/inspector.html
src/LiveDevelopment/Inspector/jsdoc.rb

I don't think these files were written by us -- they were probably created by Google or auto-generated from Google's code, so I don't think we can claim copyright over them.

src/thirdparty/CodeMirror2
Looks like a change to the submodule SHA snuck in here. Should revert this before committing.

test/spec/CSSUtils-test-files/
test/spec/DocumentCommandHandlers-test-files/

test/spec/InlineEditorProviders-test-files/
test/spec/LiveDevelopment-test-files/

It doesn't seem worth the trouble to add copyright notices to our unit test input files. These are all simple dummy files that don't contain anything important or useful. And in some cases, these unit tests are sensitive to specific line numbers -- so unless we update the testcase code, adding these copyright notices may have broken some unit tests.

@gruehle
Copy link
Member

gruehle commented Apr 25, 2012

In response to Peter's comment - Inspector.html is generated by running Inspector.json through jsdoc.rb. Jsdoc.rb was written by Jonathan, so that is Adobe owned code. Since most of the content in Inspector.html is from Inspector.json, I agree that it should not have a copyright notice.

@@ -1,3 +1,26 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LESS processor embeds comments in /* ... */ format in to generated .css file, but comments in // format are ignored (since CSS does not support this format). So, in all files except the main file (brackets.less), this comment should be updated to // format.

@redmunds
Copy link
Contributor

It looks like you missed a few files:

  • src/preferences/PreferenceStorage.js
  • src/styles/quiet-scrollbars.css
  • src/view/ViewCommandHandlers.js

@redmunds
Copy link
Contributor

I added the 3 file I listed above.

@@ -1,8 +1,27 @@
/*!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the /*! means here, but was it important? It's removed in the updated version.

@pthiess
Copy link
Contributor Author

pthiess commented Apr 26, 2012

I believe the ! would be ignored as part of the comment, this change should be save.
Added the license file in src.
Removed copyright notice in test files to avoid breaking them.
Changed comments on some less files to avoid multiplying them.

@peterflynn
Copy link
Member

Reviewed, looks good. Did a quick sanity check & ran unit tests to make sure none of the diffs somehow caused an issue.

peterflynn added a commit that referenced this pull request Apr 26, 2012
@peterflynn peterflynn merged commit 47886d1 into master Apr 26, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants