Conversation
I'm not the official reviewer, but three quick comments: src/LiveDevelopment/Inspector/inspector.html src/thirdparty/CodeMirror2 test/spec/CSSUtils-test-files/ |
In response to Peter's comment - Inspector.html is generated by running Inspector.json through jsdoc.rb. Jsdoc.rb was written by Jonathan, so that is Adobe owned code. Since most of the content in Inspector.html is from Inspector.json, I agree that it should not have a copyright notice. |
@@ -1,3 +1,26 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The LESS processor embeds comments in /* ... */ format in to generated .css file, but comments in // format are ignored (since CSS does not support this format). So, in all files except the main file (brackets.less), this comment should be updated to // format.
It looks like you missed a few files:
|
I added the 3 file I listed above. |
@@ -1,8 +1,27 @@ | |||
/*! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the /*!
means here, but was it important? It's removed in the updated version.
I believe the ! would be ignored as part of the comment, this change should be save. |
Reviewed, looks good. Did a quick sanity check & ran unit tests to make sure none of the diffs somehow caused an issue. |
Updated Copyright notice - please review and make sure that I didn't miss files which should have our copyright and that I didn't put copyright on files not created by us.