This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Code Inspection: minor fixes & more unit tests #7650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug: if one linter returns errors and another returns errors:[], the no-errors linter is shown in the panel as an empty heading. (Bug doesn't happen if it returned null instead; but both are valid ways of indicating zero errors). - Improve docs on register() - more concise, more detail on how to indicate zero errors - Add unit tests for the bug fixed above plus several more async linting cases that were fixed late in PR #6530 - Fix mislabeled existing unit test for reject()ing async linters - Fix stray whitespace that snuck into merge c3411bb
| @@ -383,7 +383,7 @@ define(function (require, exports, module) { | |||
| aborted = true; | |||
| } | |||
|
|
|||
| if (inspectionResult.result.errors) { | |||
| if (inspectionResult.result.errors.length) { | |||
There was a problem hiding this comment.
Is there any chance inspectionResult.result.errors could be undefined/null?
There was a problem hiding this comment.
Ahh, I see. The doc string specifically states that errors must be non-null. OK.
|
Changes look good. Merging. |
dangoor
added a commit
that referenced
this pull request
May 9, 2014
Code Inspection: minor fixes & more unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zero errors).