Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

myaghobi/persian translation #8421

Merged
merged 25 commits into from
Jul 19, 2014
Merged

Conversation

myaaghubi
Copy link
Contributor

update persian translation

@myaaghubi
Copy link
Contributor Author

@redmunds, what's the problem again?

@redmunds
Copy link
Contributor

There were some comments that were unnecesarily updated, but besides that, it looks ready for review. Triage Complete.

Do you know anyone that can review the string changes?

@redmunds
Copy link
Contributor

I just noticed that the indentation differences are causing errors that need to be fixed. See Travis CI Details link..

Also, there are commits showing up in list that shouldn't be there (although I don't see any changes in diff).

"INVALID_FILENAME_MESSAGE" : "نام پرونده نمی تواند شامل مقادیر زیر باشد: {0} و همچنین نمی توانید از عبارات مورد استفاده نرم افزار استفاده نمایید.",
"ENTRY_WITH_SAME_NAME_EXISTS" : "پوشه یا پروندهی با نام <span class='dialog-filename'>{0}</span> هم اکنون موجود است.",
"ERROR_CREATING_FILE_TITLE" : "خطا در ایج "ERROR_CREATING_FILE" : "بروز خطا بهنگام ایجاد {0} <span class='dialog-filename'>{1}</span>. {2}",
اد {0}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a display error in GitHub due to RTL or something? It looks like a syntax error since the previous line ends in ",...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterflynn thank for review. The main problem was on line 71.

@myaaghubi
Copy link
Contributor Author

Thank you both, After much effort, the problem was solved, but the Travis CI is very sensitive

@myaaghubi myaaghubi closed this Jul 19, 2014
@myaaghubi myaaghubi reopened this Jul 19, 2014
@redmunds
Copy link
Contributor

Thanks. Merging.

redmunds added a commit that referenced this pull request Jul 19, 2014
@redmunds redmunds merged commit 057e73c into adobe:master Jul 19, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants