This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
fix for issue 8111 exclude .sass-cache folder in project view #8458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -106,7 +106,7 @@ define(function (require, exports, module) { | |||
| * https://github.com/adobe/brackets/issues/6781 | |||
| * @type {RegExp} | |||
| */ | |||
| var _exclusionListRegEx = /\.pyc$|^\.git$|^\.gitmodules$|^\.svn$|^\.DS_Store$|^Thumbs\.db$|^\.hg$|^CVS$|^\.hgtags$|^\.idea$|^\.c9revisions$|^\.SyncArchive$|^\.SyncID$|^\.SyncIgnore$|\~$/; | |||
| var _exclusionListRegEx = /\.pyc$|^\.git$|^\.gitmodules$|^\.svn$|^\.DS_Store$|^Thumbs\.db$|^\.hg$|^CVS$|^\.hgtags$|^\.idea$|^\.c9revisions$|^\.SyncArchive$|^\.SyncID$|^\.sass-cache$|^\.SyncIgnore$|\~$/; | |||
There was a problem hiding this comment.
Nit: how about moving the new item before ^\.SyncArchive$ so it does not break those already in alphabetic order?
There was a problem hiding this comment.
Personally I don't care about alphabetizing this, but SyncArchive/SyncID/SyncIgnore are sort of a related set so it feels weird to stick this new entry in the middle of them. We should either add it at the end, or before them.
There was a problem hiding this comment.
totally agree... I honestly didn't see any order... I will change it in a few minutes.
|
Looks good -- thanks! |
peterflynn
added a commit
that referenced
this pull request
Jul 18, 2014
fix for issue 8111 exclude .sass-cache folder in project view
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the
.sass-cachefolder to the list of files and folders excluded from view in the project tree.addresses issue #8111