Navigate through Extension Manager tabs via Ctrl-(Shift)-Tab #8856
Conversation
|
Looks good to me. Thanks @marcelgerber. |
Navigate through Extension Manager tabs via Ctrl-(Shift)-Tab
|
|
||
| // navigate through tabs via Ctrl-(Shift)-Tab | ||
| $dlg.on("keyup", function (event) { | ||
| if (event.keyCode === KeyEvent.DOM_VK_TAB && event.ctrlKey) { |
There was a problem hiding this comment.
Belated question @marcelgerber @ingorichter: any idea why this doesn't get snarled up by colliding with the global Ctrl-Tab shortcut for navigating between editors? Is it because we're in a modal dialog here and native menu commands are disabled while a modal is open? (On Windows at least, the menu items themselves remain enabled though, so I'm surprised that doesn't "eat" the key event). Have we tested to make sure this works ok with the non-native HTML menu bar, e.g. on Linux?
There was a problem hiding this comment.
It works for me on Linux (Ubuntu 14.04).
There was a problem hiding this comment.
Answering the 2nd part of my own question -- it does work with HTML menus, because Dialogs disables regular KeyBindingManager handling too.
There was a problem hiding this comment.
@marcelgerber is using "keyup" events here and global shortcuts work on keydown events.
There was a problem hiding this comment.
@RaymondLim is right, I didn't get an keydown event for "Tab" key. At first I thought it was a bug...
Now that we have three tabs, it's useful to be able to navigate through the tabs via Ctrl-Tab and Ctrl-Shift-Tab.
It's the shortcut used by browsers like Chrome.