New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate through Extension Manager tabs via Ctrl-(Shift)-Tab #8856

Merged
merged 1 commit into from Sep 15, 2014

Conversation

Projects
None yet
5 participants
@MarcelGerber
Contributor

MarcelGerber commented Aug 25, 2014

Now that we have three tabs, it's useful to be able to navigate through the tabs via Ctrl-Tab and Ctrl-Shift-Tab.
It's the shortcut used by browsers like Chrome.

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Sep 15, 2014

Contributor

Looks good to me. Thanks @MarcelGerber.

Contributor

ingorichter commented Sep 15, 2014

Looks good to me. Thanks @MarcelGerber.

ingorichter added a commit that referenced this pull request Sep 15, 2014

Merge pull request #8856 from MarcelGerber/extman-navigate-tabs
Navigate through Extension Manager tabs via Ctrl-(Shift)-Tab

@ingorichter ingorichter merged commit 6b5437c into adobe:master Sep 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@MarcelGerber MarcelGerber deleted the MarcelGerber:extman-navigate-tabs branch Sep 16, 2014

// navigate through tabs via Ctrl-(Shift)-Tab
$dlg.on("keyup", function (event) {
if (event.keyCode === KeyEvent.DOM_VK_TAB && event.ctrlKey) {

This comment has been minimized.

@peterflynn

peterflynn Sep 17, 2014

Member

Belated question @MarcelGerber @ingorichter: any idea why this doesn't get snarled up by colliding with the global Ctrl-Tab shortcut for navigating between editors? Is it because we're in a modal dialog here and native menu commands are disabled while a modal is open? (On Windows at least, the menu items themselves remain enabled though, so I'm surprised that doesn't "eat" the key event). Have we tested to make sure this works ok with the non-native HTML menu bar, e.g. on Linux?

@peterflynn

peterflynn Sep 17, 2014

Member

Belated question @MarcelGerber @ingorichter: any idea why this doesn't get snarled up by colliding with the global Ctrl-Tab shortcut for navigating between editors? Is it because we're in a modal dialog here and native menu commands are disabled while a modal is open? (On Windows at least, the menu items themselves remain enabled though, so I'm surprised that doesn't "eat" the key event). Have we tested to make sure this works ok with the non-native HTML menu bar, e.g. on Linux?

This comment has been minimized.

@Mark-Simulacrum

Mark-Simulacrum Sep 17, 2014

Contributor

It works for me on Linux (Ubuntu 14.04).

@Mark-Simulacrum

Mark-Simulacrum Sep 17, 2014

Contributor

It works for me on Linux (Ubuntu 14.04).

This comment has been minimized.

@peterflynn

peterflynn Sep 17, 2014

Member

Answering the 2nd part of my own question -- it does work with HTML menus, because Dialogs disables regular KeyBindingManager handling too.

@peterflynn

peterflynn Sep 17, 2014

Member

Answering the 2nd part of my own question -- it does work with HTML menus, because Dialogs disables regular KeyBindingManager handling too.

This comment has been minimized.

@RaymondLim

RaymondLim Sep 17, 2014

Contributor

@MarcelGerber is using "keyup" events here and global shortcuts work on keydown events.

@RaymondLim

RaymondLim Sep 17, 2014

Contributor

@MarcelGerber is using "keyup" events here and global shortcuts work on keydown events.

This comment has been minimized.

@MarcelGerber

MarcelGerber Sep 18, 2014

Contributor

@RaymondLim is right, I didn't get an keydown event for "Tab" key. At first I thought it was a bug...

@MarcelGerber

MarcelGerber Sep 18, 2014

Contributor

@RaymondLim is right, I didn't get an keydown event for "Tab" key. At first I thought it was a bug...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment