New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor TimingFunction validation issue #8910

Merged
merged 4 commits into from Sep 9, 2014

Conversation

Projects
None yet
2 participants
@MarcelGerber
Contributor

MarcelGerber commented Aug 29, 2014

This fixes a rather uncommon issue in TimingFunction validation. Steps:

  1. Try to open an Inline Editor on animation-timing-function: cubic-bezier(0, 0, 0, 0,) (notice the trailing comma)

Result: Console error, no inline editor
Expected: Inline editor should auto-correct the invalid function

@redmunds redmunds self-assigned this Sep 2, 2014

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Sep 8, 2014

Contributor

Code review complete. I think this can be solved without a new regex.

Contributor

redmunds commented Sep 8, 2014

Code review complete. I think this can be solved without a new regex.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Sep 9, 2014

Contributor

@redmunds Your solution works well, therefore I used it.

Contributor

MarcelGerber commented Sep 9, 2014

@redmunds Your solution works well, therefore I used it.

@@ -215,6 +215,9 @@ define(function (require, exports, module) {
it("should correct cubic-bezier function with 5 parameters", function () {
testInvalidBezier("cubic-bezier(0, 0, 1, 1, 1)", ["cubic-bezier(0, 0, 1, 1)", "0", "0", "1", "1"]);
});
it("should correct cubic-bezier function with trailing comma", function () {

This comment has been minimized.

@redmunds

redmunds Sep 9, 2014

Contributor

Yay! Unit test!

@redmunds

redmunds Sep 9, 2014

Contributor

Yay! Unit test!

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Sep 9, 2014

Contributor

Good catch. Merging.

Contributor

redmunds commented Sep 9, 2014

Good catch. Merging.

redmunds added a commit that referenced this pull request Sep 9, 2014

Merge pull request #8910 from MarcelGerber/timing-function-editor-exc…
…eption

Fix minor TimingFunction validation issue

@redmunds redmunds merged commit 49e2004 into adobe:master Sep 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@MarcelGerber MarcelGerber deleted the MarcelGerber:timing-function-editor-exception branch Sep 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment