Update Persian translation (release 0.44) #9105

Merged
merged 2 commits into from Sep 25, 2014

Projects

None yet

3 participants

@mohammadyaghobi
Contributor

No description provided.

@mohammadyaghobi mohammadyaghobi changed the title from Update Persian translation to Update Persian translation for release 0.44 Sep 20, 2014
@mohammadyaghobi mohammadyaghobi changed the title from Update Persian translation for release 0.44 to Update Persian translation (release 0.44) Sep 20, 2014
@ingorichter ingorichter commented on the diff Sep 23, 2014
src/nls/fa-ir/strings.js
@@ -69,6 +72,7 @@ define({
"INVALID_FILENAME_MESSAGE" : "نام پرونده نمی تواند شامل مقادیر زیر باشد: {0} و همچنین نمی توانید از عبارات مورد استفاده نرم افزار استفاده نمایید.",
"ENTRY_WITH_SAME_NAME_EXISTS" : "پوشه یا پروندهی با نام <span class='dialog-filename'>{0}</span> هم اکنون موجود است.",
"ERROR_CREATING_FILE_TITLE" : "خطا در ایجاد {0}",
@ingorichter
ingorichter Sep 23, 2014 Contributor

this placeholder looks unclosed. To properly work in the template, the {} need to be in the right order.

@ingorichter
ingorichter Sep 23, 2014 Contributor

And there are some more in the file

@peterflynn
peterflynn Sep 24, 2014 Member

@ingorichter Could this be a weird bi-di rendering thing? In the notification emails for your comments, Outlook at least renders the line above with {0} grouped all together at the end of the string.

@ingorichter
ingorichter Sep 24, 2014 Contributor

@peterflynn that could be the case. Perhaps gh has issues with RTL text.

@ingorichter
ingorichter Sep 24, 2014 Contributor

the file on my machine definitely looks okay. @mohammadyaghobi please forget my previous comments. Everything looks okay in vi.

@ingorichter
Contributor

I have done a sanity check with google translate and it looks good to me.

@mohammadyaghobi
Contributor

Thank you both, please merge it.

@ingorichter ingorichter merged commit ad55f1c into adobe:master Sep 25, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ingorichter
Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment