New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Persian translation (release 0.44) #9105

Merged
merged 2 commits into from Sep 25, 2014

Conversation

Projects
None yet
3 participants
@myaghobi
Contributor

myaghobi commented Sep 14, 2014

No description provided.

@myaghobi myaghobi changed the title from Update Persian translation to Update Persian translation for release 0.44 Sep 20, 2014

@myaghobi myaghobi changed the title from Update Persian translation for release 0.44 to Update Persian translation (release 0.44) Sep 20, 2014

@@ -69,6 +72,7 @@ define({
"INVALID_FILENAME_MESSAGE" : "نام پرونده نمی تواند شامل مقادیر زیر باشد: {0} و همچنین نمی توانید از عبارات مورد استفاده نرم افزار استفاده نمایید.",
"ENTRY_WITH_SAME_NAME_EXISTS" : "پوشه یا پروندهی با نام <span class='dialog-filename'>{0}</span> هم اکنون موجود است.",
"ERROR_CREATING_FILE_TITLE" : "خطا در ایجاد {0}",

This comment has been minimized.

@ingorichter

ingorichter Sep 23, 2014

Contributor

this placeholder looks unclosed. To properly work in the template, the {} need to be in the right order.

@ingorichter

ingorichter Sep 23, 2014

Contributor

this placeholder looks unclosed. To properly work in the template, the {} need to be in the right order.

This comment has been minimized.

@ingorichter

ingorichter Sep 23, 2014

Contributor

And there are some more in the file

@ingorichter

ingorichter Sep 23, 2014

Contributor

And there are some more in the file

This comment has been minimized.

@peterflynn

peterflynn Sep 24, 2014

Member

@ingorichter Could this be a weird bi-di rendering thing? In the notification emails for your comments, Outlook at least renders the line above with {0} grouped all together at the end of the string.

@peterflynn

peterflynn Sep 24, 2014

Member

@ingorichter Could this be a weird bi-di rendering thing? In the notification emails for your comments, Outlook at least renders the line above with {0} grouped all together at the end of the string.

This comment has been minimized.

@ingorichter

ingorichter Sep 24, 2014

Contributor

@peterflynn that could be the case. Perhaps gh has issues with RTL text.

@ingorichter

ingorichter Sep 24, 2014

Contributor

@peterflynn that could be the case. Perhaps gh has issues with RTL text.

This comment has been minimized.

@ingorichter

ingorichter Sep 24, 2014

Contributor

the file on my machine definitely looks okay. @mohammadyaghobi please forget my previous comments. Everything looks okay in vi.

@ingorichter

ingorichter Sep 24, 2014

Contributor

the file on my machine definitely looks okay. @mohammadyaghobi please forget my previous comments. Everything looks okay in vi.

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Sep 24, 2014

Contributor

I have done a sanity check with google translate and it looks good to me.

Contributor

ingorichter commented Sep 24, 2014

I have done a sanity check with google translate and it looks good to me.

@myaghobi

This comment has been minimized.

Show comment
Hide comment
@myaghobi

myaghobi Sep 24, 2014

Contributor

Thank you both, please merge it.

Contributor

myaghobi commented Sep 24, 2014

Thank you both, please merge it.

ingorichter added a commit that referenced this pull request Sep 25, 2014

@ingorichter ingorichter merged commit ad55f1c into adobe:master Sep 25, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Sep 25, 2014

Contributor

Thanks @mohammadyaghobi

Contributor

ingorichter commented Sep 25, 2014

Thanks @mohammadyaghobi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment