Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

fix InlineImageViewer example extension #9191

Merged
merged 2 commits into from Oct 30, 2016

Conversation

kidwm
Copy link
Contributor

@kidwm kidwm commented Sep 22, 2014

and separate the filename and close button.

@kidwm
Copy link
Contributor Author

kidwm commented Sep 22, 2014

This issue induced by:
9a5088c

but only JavaScriptCodeHints got fixed.
c96b3df

@redmunds
Copy link
Contributor

Good catch. The styles to separate the filename and close button need to be in a stylesheet (not inline).

@nethip
Copy link
Contributor

nethip commented Mar 21, 2015

@kidwm Could you move the in line styles to a style sheet? We could then go ahead and merge this change.

@kidwm
Copy link
Contributor Author

kidwm commented Mar 22, 2015

@nethip I've done it.

@nethip
Copy link
Contributor

nethip commented Mar 26, 2015

@kidwm Thanks! I would do a quick round of testing and merge this.

@ficristo
Copy link
Collaborator

@nethip @kidwm What is the status of this?

@zaggino zaggino added this to the Release 1.9 milestone Aug 28, 2016
@ficristo
Copy link
Collaborator

LGTM, ideally the filename could be near the X to match other QuickEdit.
But at least now it works again.

@kidwm thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants