Fix "Install from URL" issue #9226

Merged
merged 2 commits into from Sep 30, 2014

Projects

None yet

4 participants

@MarcelGerber
Member

Fixes #9196. This is a minor behaviour change as well, as clicking in the body won't unfocus the search bar. But I don't think that's a bad thing.

@peterflynn peterflynn added this to the Release 0.44 milestone Sep 26, 2014
@peterflynn
Member

@MarcelGerber Is the tabIndex stuff even needed? In my testing, everything seems to work fine if you remove all the tabIndex attributes and just leave the one no-focus class.

@MarcelGerber
Member

You're right. I now applied the no-focus class to the whole dialog, so that header and footer can't be focused either.

@redmunds redmunds self-assigned this Sep 30, 2014
@redmunds
Contributor

Reviewing...

@redmunds
Contributor

Looks good. Merging.

@redmunds redmunds merged commit 6a91635 into adobe:master Sep 30, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@MarcelGerber MarcelGerber deleted the MarcelGerber:extman-install-url branch Sep 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment