New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Install from URL" issue #9226

Merged
merged 2 commits into from Sep 30, 2014

Conversation

Projects
None yet
4 participants
@MarcelGerber
Contributor

MarcelGerber commented Sep 23, 2014

Fixes #9196. This is a minor behaviour change as well, as clicking in the body won't unfocus the search bar. But I don't think that's a bad thing.

@peterflynn peterflynn added this to the Release 0.44 milestone Sep 26, 2014

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Sep 26, 2014

Member

@MarcelGerber Is the tabIndex stuff even needed? In my testing, everything seems to work fine if you remove all the tabIndex attributes and just leave the one no-focus class.

Member

peterflynn commented Sep 26, 2014

@MarcelGerber Is the tabIndex stuff even needed? In my testing, everything seems to work fine if you remove all the tabIndex attributes and just leave the one no-focus class.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Sep 29, 2014

Contributor

You're right. I now applied the no-focus class to the whole dialog, so that header and footer can't be focused either.

Contributor

MarcelGerber commented Sep 29, 2014

You're right. I now applied the no-focus class to the whole dialog, so that header and footer can't be focused either.

@redmunds redmunds self-assigned this Sep 30, 2014

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Sep 30, 2014

Contributor

Reviewing...

Contributor

redmunds commented Sep 30, 2014

Reviewing...

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Sep 30, 2014

Contributor

Looks good. Merging.

Contributor

redmunds commented Sep 30, 2014

Looks good. Merging.

redmunds added a commit that referenced this pull request Sep 30, 2014

@redmunds redmunds merged commit 6a91635 into adobe:master Sep 30, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@MarcelGerber MarcelGerber deleted the MarcelGerber:extman-install-url branch Sep 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment