Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Revert -webkit-font-smoothing to auto #9540

Closed
wants to merge 1 commit into from

Conversation

hcarvalhoalves
Copy link

This forces proper subpixel antialiasing which looks way better on Mac. Makes no difference on other platforms.

Jagged lines with -webkit-font-smoothing: antialised:
Jagged lines with -webkit-font-smoothing: antialised

Proper antialiasing with -webkit-font-smoothing: auto:
Proper antialiasing with -webkit-font-smoothing: auto

This forces proper subpixel antialiasing which looks way better on Mac. Makes no difference on other platforms.
@redmunds
Copy link
Contributor

@hcarvalhoalves According to the comment (that you removed), this was done to fix animations -- did you test how animations work with this change? We won't take this fix into core if animations are still broken.

It might be more reasonable to make this a Theme option.

cc @larz0

@hcarvalhoalves
Copy link
Author

@redmunds I removed exactly because I could not find any difference in animations, it just affected font rendering on OS X. Might want to test on other platforms though, to see if the selector should be body.platform-mac.

@larz0
Copy link
Member

larz0 commented Oct 13, 2014

This font smoothing issue has been talked about a lot, @manchagnu even added the option to the theme dialog but I can't remember what happened.

@larz0
Copy link
Member

larz0 commented Oct 13, 2014

By @manchagnu I meant @MiguelCastillo

@larz0
Copy link
Member

larz0 commented Oct 13, 2014

See #8635.

@MiguelCastillo
Copy link
Contributor

@larz0 yeah we had added it even as an option in the themes dialog, which is the place we have fonts settings. We decided we should just handle that internally and not provided as a setting. We thinking we need to rethink that decision?

@hcarvalhoalves
Copy link
Author

I saw #8635. Most editors have an option to change antialiasing methods (Textmate, Sublime Text), so it makes sense I guess.

But in the meantime, -webkit-font-smoothing: aliased triggers a different method than the default used everywhere on OS X's UI, so should be avoided for consistency sake.

@MiguelCastillo
Copy link
Contributor

@hcarvalhoalves yeah that's the PR I added the setting.

@MiguelCastillo
Copy link
Contributor

So the initial issue was this #8630. It seems like exposing this via the UI is not what we want to do because it's probably a setting that few people will use.

What about adding this as a configuration flag and document it here https://github.com/adobe/brackets/wiki/How-to-Use-Brackets#preferences?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants