Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temp dir to docker builder, move to rocky linux #20

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

bluesliverx
Copy link
Contributor

@bluesliverx bluesliverx commented Jan 31, 2022

Description

Adds the temporary directory configured in global config (or via env var).

Related Issue

Motivation and Context

There is a temp_dir configuration property in the global config, but it is not respected for certain usages, especially building the source docker image which can be quite large. After modifying this, I noticed that centos:8 images no longer work properly due its deadness. Really, it's very dead. I ported to rockylinux 8 instead which is bug-for-bug compatible.

How Has This Been Tested?

It is a non-invasive change that will need to be tested by the person who first saw signs of the bug. The build will test the rockylinux portions of the changes.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bluesliverx bluesliverx changed the title Add temp dir to docker builder Add temp dir to docker builder, move to rocky linux Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant